Conversation
igorbernstein2
requested changes
Mar 2, 2026
|
|
||
| @Nullable | ||
| public static SidebandData from(CallOptions callOptions) { | ||
| return callOptions == null ? null : callOptions.getOption(KEY); |
Contributor
There was a problem hiding this comment.
callOptions should never be null
| new SimpleForwardingClientCallListener<RespT>(responseListener) { | ||
| @Override | ||
| public void onClose(Status status, Metadata trailers) { | ||
| entry.checkAndSetTransportType(callOptions); |
Contributor
There was a problem hiding this comment.
I think you should put this in onHeaders
Contributor
Author
There was a problem hiding this comment.
Ack. I was using Status earlier to set unknown type. It was redundant. fixed it.
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
...le-cloud-bigtable/src/main/java/com/google/cloud/bigtable/gaxx/grpc/BigtableChannelPool.java
Outdated
Show resolved
Hide resolved
igorbernstein2
approved these changes
Mar 2, 2026
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Mar 24, 2026
🤖 I have created a release *beep* *boop* --- ## [2.75.0](https://togithub.com/googleapis/java-bigtable/compare/v2.74.0...v2.75.0) (2026-03-24) ### Features * Expose generated GAPIC instance admin client ([#2828](https://togithub.com/googleapis/java-bigtable/issues/2828)) ([7c42799](https://togithub.com/googleapis/java-bigtable/commit/7c42799d45dbefb172c567ab6242f2a6f27a1eba)) ### Bug Fixes * **bigtable:** Add gauge handling ([#2830](https://togithub.com/googleapis/java-bigtable/issues/2830)) ([915733b](https://togithub.com/googleapis/java-bigtable/commit/915733bbaf21626c87bb868070087c382ba0932e)) * **bigtable:** Plumb transport type correctly ([#2824](https://togithub.com/googleapis/java-bigtable/issues/2824)) ([d25f39c](https://togithub.com/googleapis/java-bigtable/commit/d25f39c1f46263bd635731aa37ba71374c64c31c)) * Fix automated backup ([#2844](https://togithub.com/googleapis/java-bigtable/issues/2844)) ([5dc6829](https://togithub.com/googleapis/java-bigtable/commit/5dc68297dc1f002cb527a710443d5c208d712bc1)) * Fix race in emulator controller ([#2836](https://togithub.com/googleapis/java-bigtable/issues/2836)) ([17707be](https://togithub.com/googleapis/java-bigtable/commit/17707be3f4bfede9e4541d00350c400de937e3b6)) * Use all known headers to detect connectivity errors ([#2841](https://togithub.com/googleapis/java-bigtable/issues/2841)) ([6466166](https://togithub.com/googleapis/java-bigtable/commit/6466166b417c9a5052c512f38047a7fac19b5d75)) ### Dependencies * Update shared dependencies ([#2850](https://togithub.com/googleapis/java-bigtable/issues/2850)) ([fb437e0](https://togithub.com/googleapis/java-bigtable/commit/fb437e074ee328d57c00807d4afcaf26dd78aea7)) ### Documentation * **bigtable:** Expose Admin API Stubs in Javadoc ([#2835](https://togithub.com/googleapis/java-bigtable/issues/2835)) ([b7a0232](https://togithub.com/googleapis/java-bigtable/commit/b7a0232b1cf9639f5c529240482a99c94d950931)) * **bigtable:** Expose Base Admin Clients in Javadoc ([#2833](https://togithub.com/googleapis/java-bigtable/issues/2833)) ([2933ef6](https://togithub.com/googleapis/java-bigtable/commit/2933ef6419ec6ec6e3220a6bab03bb0c2cf7cd0d)) --- This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.