Skip to content

Revert "[CHANGE ME] Re-generated pubsub to pick up changes in the API or client library generator."#9086

Closed
plamut wants to merge 1 commit into
masterfrom
revert-9078-autosynth-pubsub
Closed

Revert "[CHANGE ME] Re-generated pubsub to pick up changes in the API or client library generator."#9086
plamut wants to merge 1 commit into
masterfrom
revert-9078-autosynth-pubsub

Conversation

@plamut

@plamut plamut commented Aug 23, 2019

Copy link
Copy Markdown
Contributor

Reverts #9078

As per offline discussion, we might not want to have these changes in the upcoming GA release, thus reverting them.

… or client library generator. (#9078)"

This reverts commit bc9ea52.
@plamut plamut added the api: pubsub Issues related to the Pub/Sub API. label Aug 23, 2019
@plamut plamut requested a review from anguillanneuf as a code owner August 23, 2019 08:15
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 23, 2019
@plamut plamut requested a review from pradn August 23, 2019 08:15
@plamut

plamut commented Aug 23, 2019

Copy link
Copy Markdown
Contributor Author

As per discussion on chat - we do not need to revert the changes. They are similar to Ordering Keys, which have already been merged and documented quite some time ago, despite the Python client not supporting them yet.

@plamut plamut closed this Aug 23, 2019
@tseaver tseaver deleted the revert-9078-autosynth-pubsub branch September 5, 2019 00:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants