Skip to content

[CHANGE ME] Re-generated pubsub to pick up changes in the API or client library generator.#9078

Merged
plamut merged 1 commit into
masterfrom
autosynth-pubsub
Aug 22, 2019
Merged

[CHANGE ME] Re-generated pubsub to pick up changes in the API or client library generator.#9078
plamut merged 1 commit into
masterfrom
autosynth-pubsub

Conversation

@yoshi-automation

@yoshi-automation yoshi-automation commented Aug 22, 2019

Copy link
Copy Markdown
Contributor

This PR was generated using Autosynth. 🌈

Here's the log from Synthtool:

synthtool > Executing /tmpfs/src/git/autosynth/working_repo/pubsub/synth.py.
synthtool > Ensuring dependencies.
synthtool > Pulling artman image.
latest: Pulling from googleapis/artman
Digest: sha256:38a27ba6245f96c3e86df7acb2ebcc33b4f186d9e475efe2d64303aec3d4e0ea
Status: Image is up to date for googleapis/artman:latest
synthtool > Cloning googleapis.
synthtool > Running generator for google/pubsub/artman_pubsub.yaml.
synthtool > Generated code into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/pubsub-v1.
synthtool > Copy: /home/kbuilder/.cache/synthtool/googleapis/google/pubsub/v1/pubsub.proto to /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/pubsub-v1/google/cloud/pubsub_v1/proto/pubsub.proto
synthtool > Placed proto files into /home/kbuilder/.cache/synthtool/googleapis/artman-genfiles/python/pubsub-v1/google/cloud/pubsub_v1/proto.
synthtool > Replaced 'from google.cloud import pubsub_v1' in tests/unit/gapic/v1/test_publisher_client_v1.py.
synthtool > Replaced ' pubsub_v1' in tests/unit/gapic/v1/test_publisher_client_v1.py.
synthtool > Replaced 'from google.cloud import pubsub_v1' in tests/unit/gapic/v1/test_subscriber_client_v1.py.
synthtool > Replaced ' pubsub_v1' in tests/unit/gapic/v1/test_subscriber_client_v1.py.
synthtool > Replaced '# The name of the interface for this client. This is the key used to' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '# The name of the interface for this client. This is the key used to' in google/cloud/pubsub_v1/gapic/subscriber_client.py.
synthtool > Replaced 'import google.api_core.gapic_v1.method\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'DESCRIPTOR = _MESSAGESTORAGEPOLICY,\n\\s+__module__.*\n\\s+,\n\\s+__doc__ = """' in google/cloud/pubsub_v1/proto/pubsub_pb2.py.
synthtool > No replacements made in google/cloud/pubsub_v1/gapic/subscriber_client.py for pattern subscription \(str\): The subscription whose backlog .*
(.*
)+?\s+Format is .*, maybe replacement is not longer needed?
synthtool > Replaced 'import functools\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'import pkg_resources\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'class PublisherClient' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced 'client_config \\(dict\\): DEPRECATED.' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '# Raise deprecation warnings .*\n.*\n.*\n.*\n.*\n.*\n' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '~google.api_core.page_iterator.PageIterator' in google/cloud/pubsub_v1/gapic/publisher_client.py.
synthtool > Replaced '~google.api_core.page_iterator.PageIterator' in google/cloud/pubsub_v1/gapic/subscriber_client.py.
synthtool > Replaced 'from google.iam.v1 import iam_policy_pb2' in google/cloud/pubsub_v1/gapic/transports/publisher_grpc_transport.py.
synthtool > Replaced 'from google.iam.v1 import iam_policy_pb2' in google/cloud/pubsub_v1/gapic/transports/subscriber_grpc_transport.py.
.coveragerc
.flake8
MANIFEST.in
noxfile.py.j2
setup.cfg
Running session blacken
Creating virtual environment (virtualenv) using python3.6 in .nox/blacken
pip install black==19.3b0
black docs google tests noxfile.py setup.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/__init__.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/subscriber_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/publisher_client_config.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/transports/publisher_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/transports/subscriber_grpc_transport.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/subscriber_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/gapic/publisher_client.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/proto/pubsub_pb2_grpc.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/tests/system/gapic/v1/test_system_publisher_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/noxfile.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/tests/unit/gapic/v1/test_publisher_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/tests/unit/gapic/v1/test_subscriber_client_v1.py
reformatted /tmpfs/src/git/autosynth/working_repo/pubsub/google/cloud/pubsub_v1/proto/pubsub_pb2.py
All done! ✨ 🍰 ✨
15 files reformatted, 49 files left unchanged.
Session blacken was successful.
synthtool > Cleaned up 3 temporary directories.
synthtool > Wrote metadata to synth.metadata.

@yoshi-automation yoshi-automation added the api: pubsub Issues related to the Pub/Sub API. label Aug 22, 2019
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Aug 22, 2019
plamut
plamut reviewed Aug 22, 2019
View reviewed changes

@plamut plamut left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The changes seem fine on the surface, but this is the first time I see this, and cannot say for certain whether this change is intended or not, and what the requirements are. Will seek for more info.

@anguillanneuf Do you know anything about this new thing?

@anguillanneuf

anguillanneuf commented Aug 22, 2019

Copy link
Copy Markdown
Contributor

@plamut Yes, I'm aware. This is a private alpha feature for now. The goal for this feature is to offload bad messages to a separate topic so they don't clog up the system.

anguillanneuf
anguillanneuf approved these changes Aug 22, 2019
View reviewed changes

@anguillanneuf anguillanneuf left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the ping. LGTM.

@plamut plamut merged commit bc9ea52 into master Aug 22, 2019
@plamut

plamut commented Aug 22, 2019 •
edited
Loading

Copy link
Copy Markdown
Contributor

Oh... I should have edited the merge message, meh. :/
Sorry!

plamut added a commit that referenced this pull request Aug 23, 2019
@plamut
Revert "[CHANGE ME] Re-generated pubsub to pick up changes in the API…
d10c9e1 
… or client library generator. (#9078)"

This reverts commit bc9ea52.
@plamut plamut mentioned this pull request Aug 23, 2019
Closed
HemangChothani pushed a commit to HemangChothani/google-cloud-python that referenced this pull request Aug 29, 2019
@yoshi-automation @plamut
[CHANGE ME] Re-generated pubsub to pick up changes in the API or clie…
69476c7 
…nt library generator. (googleapis#9078)
emar-kar pushed a commit to MaxxleLLC/google-cloud-python that referenced this pull request Sep 18, 2019
@yoshi-automation @emar-kar
[CHANGE ME] Re-generated pubsub to pick up changes in the API or clie…
f58d5a8 
…nt library generator. (googleapis#9078)
@TrangPham

TrangPham commented Dec 6, 2019

Copy link
Copy Markdown

When would this feature be available to end users?

@plamut

plamut commented Dec 6, 2019

Copy link
Copy Markdown
Contributor

@TrangPham I think the target is Q1 2020 - but please consider that an unofficial answer for now.

(cc: @hongalex)

parthea pushed a commit that referenced this pull request Mar 2, 2026
@yoshi-automation @plamut
[CHANGE ME] Re-generated pubsub to pick up changes in the API or clie…
bd0281f 
…nt library generator. (#9078)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

2 more reviewers

@plamut plamut plamut left review comments

@anguillanneuf anguillanneuf anguillanneuf approved these changes

Reviewers whose approvals may not affect merge requirements

Assignees

No one assigned

Labels

api: pubsub Issues related to the Pub/Sub API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@yoshi-automation @anguillanneuf @plamut @TrangPham @googlebot