-
Notifications
You must be signed in to change notification settings - Fork 1.1k
chore: update googleapis commitish to ea20a7c #13695
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -20,7 +20,7 @@ If you are using Maven, add this to your pom.xml file: | |||||
|
|
||||||
| ```xml | ||||||
| <dependency> | ||||||
| <groupId>com.google.api-ads</groupId> | ||||||
| <groupId>com.google.api-ad</groupId> | ||||||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. The Maven group ID has been incorrectly changed from
Suggested change
|
||||||
| <artifactId>ad-manager</artifactId> | ||||||
| <version>0.53.0</version> | ||||||
| </dependency> | ||||||
|
|
@@ -29,13 +29,13 @@ If you are using Maven, add this to your pom.xml file: | |||||
| If you are using Gradle without BOM, add this to your dependencies: | ||||||
|
|
||||||
| ```Groovy | ||||||
| implementation 'com.google.api-ads:ad-manager:0.53.0' | ||||||
| implementation 'com.google.api-ad:ad-manager:0.53.0' | ||||||
| ``` | ||||||
|
|
||||||
| If you are using SBT, add this to your dependencies: | ||||||
|
|
||||||
| ```Scala | ||||||
| libraryDependencies += "com.google.api-ads" % "ad-manager" % "0.53.0" | ||||||
| libraryDependencies += "com.google.api-ad" % "ad-manager" % "0.53.0" | ||||||
| ``` | ||||||
|
|
||||||
| ## Authentication | ||||||
|
|
@@ -157,8 +157,8 @@ Java is a registered trademark of Oracle and/or its affiliates. | |||||
| [product-docs]: https://developers.google.com/ad-manager/api/beta | ||||||
| [javadocs]: https://cloud.google.com/java/docs/reference/ad-manager/latest/overview | ||||||
| [stability-image]: https://img.shields.io/badge/stability-preview-yellow | ||||||
| [maven-version-image]: https://img.shields.io/maven-central/v/com.google.api-ads/ad-manager.svg | ||||||
| [maven-version-link]: https://central.sonatype.com/artifact/com.google.api-ads/ad-manager/0.53.0 | ||||||
| [maven-version-image]: https://img.shields.io/maven-central/v/com.google.api-ad/ad-manager.svg | ||||||
| [maven-version-link]: https://central.sonatype.com/artifact/com.google.api-ad/ad-manager/0.53.0 | ||||||
| [authentication]: https://github.com/googleapis/google-cloud-java#authentication | ||||||
| [auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes | ||||||
| [predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles | ||||||
|
|
||||||
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The distribution name has been incorrectly changed from
com.google.api-ads:ad-managertocom.google.api-ad:ad-manager. The correct Maven group ID for Google Ads / Ad Manager API artifacts iscom.google.api-ads. Changing this tocom.google.api-adwill break dependency resolution, builds, and library distribution. Please revert this change to usecom.google.api-ads:ad-manager. Once this is reverted in the metadata, the generated files (such as README.md and stub settings) should be regenerated to use the correct group ID.