Skip to content
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
The table of contents is too big for display.
Diff view
Diff view
  •  
  •  
  •  
2 changes: 1 addition & 1 deletion gapic-libraries-bom/pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -16,7 +16,7 @@
<parent>
<artifactId>google-cloud-pom-parent</artifactId>
<groupId>com.google.cloud</groupId>
<version>1.89.0-SNAPSHOT</version><!-- {x-version-update:google-cloud-pom-parent:current} -->
<version>1.88.0</version><!-- {x-version-update:google-cloud-pom-parent:current} -->
<relativePath>../google-cloud-pom-parent/pom.xml</relativePath>
</parent>

Expand Down
2 changes: 1 addition & 1 deletion java-admanager/.repo-metadata.json
Original file line number Diff line number Diff line change
Expand Up @@ -9,7 +9,7 @@
"language": "java",
"repo": "googleapis/google-cloud-java",
"repo_short": "java-admanager",
"distribution_name": "com.google.api-ads:ad-manager",
"distribution_name": "com.google.api-ad:ad-manager",

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The distribution name has been incorrectly changed from com.google.api-ads:ad-manager to com.google.api-ad:ad-manager. The correct Maven group ID for Google Ads / Ad Manager API artifacts is com.google.api-ads. Changing this to com.google.api-ad will break dependency resolution, builds, and library distribution. Please revert this change to use com.google.api-ads:ad-manager. Once this is reverted in the metadata, the generated files (such as README.md and stub settings) should be regenerated to use the correct group ID.

Suggested change
"distribution_name": "com.google.api-ad:ad-manager",
"distribution_name": "com.google.api-ads:ad-manager",

"api_id": "admanager.googleapis.com",
"library_type": "GAPIC_AUTO",
"requires_billing": true
Expand Down
10 changes: 5 additions & 5 deletions java-admanager/README.md
Original file line number Diff line number Diff line change
Expand Up @@ -20,7 +20,7 @@ If you are using Maven, add this to your pom.xml file:

```xml
<dependency>
<groupId>com.google.api-ads</groupId>
<groupId>com.google.api-ad</groupId>

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

critical

The Maven group ID has been incorrectly changed from com.google.api-ads to com.google.api-ad. Please revert this to com.google.api-ads to ensure correct dependency resolution. Note that this file is auto-generated, so the root cause in java-admanager/.repo-metadata.json must be fixed first.

Suggested change
<groupId>com.google.api-ad</groupId>
<groupId>com.google.api-ads</groupId>

<artifactId>ad-manager</artifactId>
<version>0.53.0</version>
</dependency>
Expand All @@ -29,13 +29,13 @@ If you are using Maven, add this to your pom.xml file:
If you are using Gradle without BOM, add this to your dependencies:

```Groovy
implementation 'com.google.api-ads:ad-manager:0.53.0'
implementation 'com.google.api-ad:ad-manager:0.53.0'
```

If you are using SBT, add this to your dependencies:

```Scala
libraryDependencies += "com.google.api-ads" % "ad-manager" % "0.53.0"
libraryDependencies += "com.google.api-ad" % "ad-manager" % "0.53.0"
```

## Authentication
Expand Down Expand Up @@ -157,8 +157,8 @@ Java is a registered trademark of Oracle and/or its affiliates.
[product-docs]: https://developers.google.com/ad-manager/api/beta
[javadocs]: https://cloud.google.com/java/docs/reference/ad-manager/latest/overview
[stability-image]: https://img.shields.io/badge/stability-preview-yellow
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.api-ads/ad-manager.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.api-ads/ad-manager/0.53.0
[maven-version-image]: https://img.shields.io/maven-central/v/com.google.api-ad/ad-manager.svg
[maven-version-link]: https://central.sonatype.com/artifact/com.google.api-ad/ad-manager/0.53.0
[authentication]: https://github.com/googleapis/google-cloud-java#authentication
[auth-scopes]: https://developers.google.com/identity/protocols/oauth2/scopes
[predefined-iam-roles]: https://cloud.google.com/iam/docs/understanding-roles#predefined_roles
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -294,7 +294,7 @@ protected AdBreakServiceStubSettings(Builder settingsBuilder) throws IOException
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -374,7 +374,7 @@ protected AdReviewCenterAdServiceStubSettings(Builder settingsBuilder) throws IO
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -408,7 +408,7 @@ protected AdUnitServiceStubSettings(Builder settingsBuilder) throws IOException
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -339,7 +339,7 @@ protected ApplicationServiceStubSettings(Builder settingsBuilder) throws IOExcep
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ protected AudienceSegmentServiceStubSettings(Builder settingsBuilder) throws IOE
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -281,7 +281,7 @@ protected BandwidthGroupServiceStubSettings(Builder settingsBuilder) throws IOEx
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ protected BrowserLanguageServiceStubSettings(Builder settingsBuilder) throws IOE
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ protected BrowserServiceStubSettings(Builder settingsBuilder) throws IOException
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -309,7 +309,7 @@ protected CmsMetadataKeyServiceStubSettings(Builder settingsBuilder) throws IOEx
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -318,7 +318,7 @@ protected CmsMetadataValueServiceStubSettings(Builder settingsBuilder) throws IO
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ protected CompanyServiceStubSettings(Builder settingsBuilder) throws IOException
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -307,7 +307,7 @@ protected ContactServiceStubSettings(Builder settingsBuilder) throws IOException
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ protected ContentBundleServiceStubSettings(Builder settingsBuilder) throws IOExc
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ protected ContentLabelServiceStubSettings(Builder settingsBuilder) throws IOExce
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -268,7 +268,7 @@ protected ContentServiceStubSettings(Builder settingsBuilder) throws IOException
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ protected CreativeTemplateServiceStubSettings(Builder settingsBuilder) throws IO
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -340,7 +340,7 @@ protected CustomFieldServiceStubSettings(Builder settingsBuilder) throws IOExcep
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -373,7 +373,7 @@ protected CustomTargetingKeyServiceStubSettings(Builder settingsBuilder) throws
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ protected CustomTargetingValueServiceStubSettings(Builder settingsBuilder) throw
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -295,7 +295,7 @@ protected DeviceCapabilityServiceStubSettings(Builder settingsBuilder) throws IO
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -287,7 +287,7 @@ protected DeviceCategoryServiceStubSettings(Builder settingsBuilder) throws IOEx
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -297,7 +297,7 @@ protected DeviceManufacturerServiceStubSettings(Builder settingsBuilder) throws
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -350,7 +350,7 @@ protected EntitySignalsMappingServiceStubSettings(Builder settingsBuilder) throw
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -271,7 +271,7 @@ protected GeoTargetServiceStubSettings(Builder settingsBuilder) throws IOExcepti
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -328,7 +328,7 @@ protected LabelServiceStubSettings(Builder settingsBuilder) throws IOException {
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ protected LineItemServiceStubSettings(Builder settingsBuilder) throws IOExceptio
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ protected LinkedDeviceServiceStubSettings(Builder settingsBuilder) throws IOExce
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ protected McmEarningsServiceStubSettings(Builder settingsBuilder) throws IOExcep
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -280,7 +280,7 @@ protected MobileCarrierServiceStubSettings(Builder settingsBuilder) throws IOExc
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -279,7 +279,7 @@ protected MobileDeviceServiceStubSettings(Builder settingsBuilder) throws IOExce
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -300,7 +300,7 @@ protected MobileDeviceSubmodelServiceStubSettings(Builder settingsBuilder) throw
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ protected NetworkServiceStubSettings(Builder settingsBuilder) throws IOException
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -290,7 +290,7 @@ protected OperatingSystemServiceStubSettings(Builder settingsBuilder) throws IOE
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -305,7 +305,7 @@ protected OperatingSystemVersionServiceStubSettings(Builder settingsBuilder) thr
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -269,7 +269,7 @@ protected OrderServiceStubSettings(Builder settingsBuilder) throws IOException {
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -343,7 +343,7 @@ protected PlacementServiceStubSettings(Builder settingsBuilder) throws IOExcepti
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -317,7 +317,7 @@ protected PrivateAuctionDealServiceStubSettings(Builder settingsBuilder) throws
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ protected PrivateAuctionServiceStubSettings(Builder settingsBuilder) throws IOEx
@Override
protected LibraryMetadata getLibraryMetadata() {
return LibraryMetadata.newBuilder()
.setArtifactName("com.google.api-ads:ad-manager")
.setArtifactName("com.google.api-ad:ad-manager")
.setRepository("googleapis/google-cloud-java")
.setVersion(Version.VERSION)
.build();
Expand Down
Loading
Loading