chore: update googleapis commitish to ea20a7c#13695
Conversation
There was a problem hiding this comment.
Code Review
This pull request introduces updates across several Google Cloud Java libraries, including adding the IdentityType enum to ReasoningEngineSpec in java-aiplatform, introducing etag fields and the ML_DSA_65 signature algorithm in java-binary-authorization, and adding AgentCard and validation error tracking in java-ces. However, a critical issue was identified in java-admanager where the Maven group ID was incorrectly changed from com.google.api-ads to com.google.api-ad across metadata, README, and stub settings, which will break dependency resolution and must be reverted.
| "repo": "googleapis/google-cloud-java", | ||
| "repo_short": "java-admanager", | ||
| "distribution_name": "com.google.api-ads:ad-manager", | ||
| "distribution_name": "com.google.api-ad:ad-manager", |
There was a problem hiding this comment.
The distribution name has been incorrectly changed from com.google.api-ads:ad-manager to com.google.api-ad:ad-manager. The correct Maven group ID for Google Ads / Ad Manager API artifacts is com.google.api-ads. Changing this to com.google.api-ad will break dependency resolution, builds, and library distribution. Please revert this change to use com.google.api-ads:ad-manager. Once this is reverted in the metadata, the generated files (such as README.md and stub settings) should be regenerated to use the correct group ID.
| "distribution_name": "com.google.api-ad:ad-manager", | |
| "distribution_name": "com.google.api-ads:ad-manager", |
| ```xml | ||
| <dependency> | ||
| <groupId>com.google.api-ads</groupId> | ||
| <groupId>com.google.api-ad</groupId> |
There was a problem hiding this comment.
The Maven group ID has been incorrectly changed from com.google.api-ads to com.google.api-ad. Please revert this to com.google.api-ads to ensure correct dependency resolution. Note that this file is auto-generated, so the root cause in java-admanager/.repo-metadata.json must be fixed first.
| <groupId>com.google.api-ad</groupId> | |
| <groupId>com.google.api-ads</groupId> |
Updated googleapis commitish in librarian.yaml to googleapis/googleapis@ea20a7c
💡 Note: If this PR is still open when the daily update workflow runs next, it will be closed and replaced with a new PR containing the latest updates.