Fix BigQuery JDBC manual commit mode region mismatch for non-US locations#13285
Open
yagudin10 wants to merge 1 commit into
Open
Fix BigQuery JDBC manual commit mode region mismatch for non-US locations#13285yagudin10 wants to merge 1 commit into
yagudin10 wants to merge 1 commit into
Conversation
Contributor
There was a problem hiding this comment.
Code Review
This pull request updates BigQueryImpl.java to explicitly set the location for a new job using the configured options when generating a default JobId. This prevents jobs from being created with an incorrect location, such as when running in transaction mode outside the US. Additionally, telemetry tests in HttpBigQueryRpcTest.java have been updated to reflect the inclusion of the location in the job ID. No review comments were provided.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Problem
Manual commit mode fails when using BigQuery JDBC with non-US datasets.
STR (Steps to Reproduce)
EU) viaLocationpropertyEnableSession = 1)ER (Expected Result)
AR (Actual Result)
Query execution fails with:
Sample java code: