Skip to content

fix(firestore): increase ITShutdownTest timeout to 50s#13199

Merged
blakeli0 merged 1 commit into
googleapis:mainfrom
blakeli0:fix-firestore-shutdown-timeout
May 15, 2026
Merged

fix(firestore): increase ITShutdownTest timeout to 50s#13199
blakeli0 merged 1 commit into
googleapis:mainfrom
blakeli0:fix-firestore-shutdown-timeout

Conversation

@blakeli0
Copy link
Copy Markdown
Contributor

@blakeli0 blakeli0 commented May 14, 2026

Increases the timeout rule in ITShutdownTest from 5 seconds to 50 seconds. This accommodates the 45-second backend priming budget established in ITBaseTest while still protecting CI from hanging indefinitely if a shutdown deadlock occurs.

fixes: #13198

@blakeli0 blakeli0 requested review from a team as code owners May 14, 2026 19:06
@blakeli0 blakeli0 requested a review from wu-hui May 14, 2026 19:07
Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request increases the test timeout in ITShutdownTest.java from 5 seconds to 50 seconds to accommodate backend priming and shutdown execution. I have no feedback to provide as there were no review comments to evaluate.

@blakeli0 blakeli0 merged commit d432b35 into googleapis:main May 15, 2026
169 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[java-firestore] Flaky test ITShutdownTest#closeSuccess_withListenerRemove

2 participants