This repository was archived by the owner on Apr 3, 2024. It is now read-only.
fix: source mapping original path instead of user-provided input#978
Merged
Conversation
Codecov Report
@@ Coverage Diff @@
## master #978 +/- ##
=======================================
Coverage 66.78% 66.78%
=======================================
Files 20 20
Lines 1668 1668
Branches 340 340
=======================================
Hits 1114 1114
Misses 475 475
Partials 79 79
Continue to review full report at Codecov.
|
mctavish
reviewed
Jun 17, 2021
| * @constructor | ||
| */ | ||
| constructor() { | ||
| constructor(readonly logger: Logger) { |
Author
There was a problem hiding this comment.
The create() function is actually not a static function of this class, marking the constructor as private will change the usage of this function in all places. I think for this PR, it is better to keep it as it is, what do you think?
JustinBeckwith
approved these changes
Jun 17, 2021
Contributor
JustinBeckwith
left a comment
There was a problem hiding this comment.
LGTM from a TypeScript perspective
added 4 commits
June 18, 2021 17:39
…-nodejs into nodejs-agent-srcmap
mctavish
approved these changes
Jun 22, 2021
Contributor
mctavish
left a comment
There was a problem hiding this comment.
One small change to make, but looks good.
gcf-merge-on-green Bot
pushed a commit
that referenced
this pull request
Jun 24, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [5.2.5](https://www.github.com/googleapis/cloud-debug-nodejs/compare/v5.2.4...v5.2.5) (2021-06-24) ### Bug Fixes * Add debugging information for sourcemapper ([#977](https://www.github.com/googleapis/cloud-debug-nodejs/issues/977)) ([b647106](https://www.github.com/googleapis/cloud-debug-nodejs/commit/b6471062a24894c7a427ad29ece0819b3b383352)) * source mapping original path instead of user-provided input ([#978](https://www.github.com/googleapis/cloud-debug-nodejs/issues/978)) ([108225c](https://www.github.com/googleapis/cloud-debug-nodejs/commit/108225cfadbef2c6b3b0c4f4be06a8ea983a0476)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Uses the original source path in the mapInfo instead of user-provided input to check the generated sources, so that when the user provided a partial match of the file, we can still correctly map the original file to the generated file.
This PR is based on PR #977
Fixes #963