Skip to content
This repository was archived by the owner on Apr 3, 2024. It is now read-only.

fix: Add debugging information for sourcemapper#977

Merged
mctavish merged 5 commits into
googleapis:masterfrom
Louis-Ye:srcmap-debuginfo
Jun 18, 2021
Merged

fix: Add debugging information for sourcemapper#977
mctavish merged 5 commits into
googleapis:masterfrom
Louis-Ye:srcmap-debuginfo

Conversation

@Louis-Ye
Copy link
Copy Markdown

This PR is to add debugging information to source mapper so that it is easier to debug related issues from users.

Fixes #932

@Louis-Ye Louis-Ye requested review from a team June 16, 2021 15:38
@product-auto-label product-auto-label Bot added the api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. label Jun 16, 2021
@google-cla google-cla Bot added the cla: yes This human has signed the Contributor License Agreement. label Jun 16, 2021
@codecov
Copy link
Copy Markdown

codecov Bot commented Jun 16, 2021

Codecov Report

Merging #977 (a873a02) into master (afc5e3a) will decrease coverage by 0.05%.
The diff coverage is 89.65%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #977      +/-   ##
==========================================
- Coverage   66.84%   66.78%   -0.06%     
==========================================
  Files          20       20              
  Lines        1677     1668       -9     
  Branches      343      340       -3     
==========================================
- Hits         1121     1114       -7     
+ Misses        477      475       -2     
  Partials       79       79              
Impacted Files Coverage Δ
src/agent/config.ts 100.00% <ø> (ø)
src/agent/v8/v8inspector.ts 80.95% <71.42%> (-7.46%) ⬇️
src/agent/v8/inspector-debugapi.ts 84.95% <88.88%> (+1.03%) ⬆️
src/agent/debuglet.ts 80.64% <100.00%> (ø)
src/agent/io/sourcemapper.ts 87.91% <100.00%> (+1.83%) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update afc5e3a...a873a02. Read the comment docs.

Comment thread test/test-sourcemapper.ts Outdated
Comment thread test/test-sourcemapper.ts Outdated
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

api: clouddebugger Issues related to the googleapis/cloud-debug-nodejs API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Could not determine the output file associated with the transpiled input file

2 participants