Remove creation_ddl from model#42
Merged
Merged
Conversation
This really belongs in the update code, so move it from model.Model to admin.update.CreateTable. Also because creating the table fresh on a new database also requires involve adding secondary indices, add a helper method that takes a model and returns the list of ddl necessary to set up the table for that model.
akefeli
approved these changes
Mar 11, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This really belongs in the update code, so move it from model.Model to
admin.update.CreateTable. Also because creating the table fresh on a new
database also requires involve adding secondary indices, add a helper
method that takes a model and returns the list of ddl necessary to set
up the table for that model.
Note: This PR depends on #40