Refactor updates and add index-related updates#40
Merged
Conversation
- Separated out the different types of updates that had been jammed into one type. ColumnUpdate now AddColumn/DropColumn/AlterColumn, IndexUpdate now AddIndex/DropIndex. - Switched from assertions to SpannerErrors, made error messages more consistent and helpful - Implemented DropTable updates - Implemented AddIndex and DropIndex updates - I tested this in a Python shell and realized that the metadata caching was incompatible with migrations (as the metadata changes after a migration is run), so I removed that
This was referenced Mar 8, 2019
akefeli
approved these changes
Mar 8, 2019
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
one type. ColumnUpdate now AddColumn/DropColumn/AlterColumn, IndexUpdate
now AddIndex/DropIndex.
consistent and helpful
was incompatible with migrations (as the metadata changes after a
migration is run), so I removed that