Skip to content

#621 - add the logging of requestId (port to 2.35.*)#1033

Merged
1 commit merged into
gooddata:2.35-portfrom
daniel-rusnak:621-gh-issue-port-2.35
Jun 21, 2021
Merged

#621 - add the logging of requestId (port to 2.35.*)#1033
1 commit merged into
gooddata:2.35-portfrom
daniel-rusnak:621-gh-issue-port-2.35

Conversation

@daniel-rusnak

Copy link
Copy Markdown
Contributor

Added 'RequestIdInterceptor' on the apache http client to generate 'requestId' for the client requests. It wasn't added to Spring 'RestTemplate' because the Sardine client doesn't use it.

Added 'ResponseMissingRequestIdInterceptor' on the apache http client to add missing 'X-GDC-REQUEST' header in responses coming from WebDav server.

Added the 'requestId' information to exceptions to easier tracking the problem.

@ghost

ghost commented Jun 15, 2021

Copy link
Copy Markdown

Build succeeded (check pipeline).

@daniel-rusnak daniel-rusnak force-pushed the 621-gh-issue-port-2.35 branch from fbca21d to 26ab992 Compare June 15, 2021 19:43
@ghost

ghost commented Jun 15, 2021

Copy link
Copy Markdown

Build succeeded (check pipeline).

@daniel-rusnak

Copy link
Copy Markdown
Contributor Author

The @peter-plochan comments from #1032 (review) fixed also here.

@ghost

ghost commented Jun 17, 2021

Copy link
Copy Markdown

Build succeeded (check pipeline).

@daniel-rusnak

Copy link
Copy Markdown
Contributor Author

The @jimirocks comments from #1032 fixed also here.

Added 'RequestIdInterceptor' on the apache http client to generate 'requestId' for the client requests. It wasn't added to Spring 'RestTemplate' because the Sardine client doesn't use it.

Added 'ResponseMissingRequestIdInterceptor' on the apache http client to add missing 'X-GDC-REQUEST' header in responses coming from WebDav server.

Added the 'requestId' information to exceptions to easier tracking the problem.
@daniel-rusnak daniel-rusnak force-pushed the 621-gh-issue-port-2.35 branch from 0616dbe to 9705937 Compare June 20, 2021 20:56
@ghost

ghost commented Jun 20, 2021

Copy link
Copy Markdown

Build succeeded (check pipeline).

@ghost ghost removed the merge label Jun 21, 2021
@ghost ghost merged commit da72954 into gooddata:2.35-port Jun 21, 2021
@ghost

ghost commented Jun 21, 2021

Copy link
Copy Markdown

@liry liry added enhancement and removed bug labels Jun 25, 2021
@liry liry added this to the 2.36.0+api1 milestone Jun 25, 2021
@liry

liry commented Jun 25, 2021

Copy link
Copy Markdown
Contributor

Separate issue #1035 created for this port to version 2.x.x

This pull request was closed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

4 participants