#621 - add the logging of requestId#1032
Merged
1 commit merged intoJun 21, 2021
Merged
Conversation
|
Build succeeded (check pipeline). |
peter-plochan
requested changes
Jun 15, 2021
peter-plochan
left a comment
Contributor
There was a problem hiding this comment.
Great work 👍
Just minor things to consider
38f0042 to
9c1326b
Compare
|
Build succeeded (check pipeline). |
jimirocks
requested changes
Jun 16, 2021
jimirocks
left a comment
Contributor
There was a problem hiding this comment.
GoodJob, but please note comments
9c1326b to
6b2b720
Compare
|
Build succeeded (check pipeline). |
peter-plochan
approved these changes
Jun 18, 2021
6b2b720 to
4dadbb7
Compare
|
Build succeeded (check pipeline). |
Added 'RequestIdInterceptor' on the apache http client to generate 'requestId' for the client requests. It wasn't added to Spring 'RestTemplate' because the Sardine client doesn't use it. Added 'ResponseMissingRequestIdInterceptor' on the apache http client to add missing 'X-GDC-REQUEST' header in responses coming from WebDav server. Added the 'requestId' information to exceptions to easier tracking the problem.
4dadbb7 to
7af7287
Compare
|
Build succeeded (check pipeline). |
jimirocks
approved these changes
Jun 21, 2021
|
Build succeeded (gate pipeline).
|
This pull request was closed.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
5 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added 'RequestIdInterceptor' on the apache http client to generate 'requestId' for the client requests. It wasn't added to Spring 'RestTemplate' because the Sardine client doesn't use it.
Added 'ResponseMissingRequestIdInterceptor' on the apache http client to add missing 'X-GDC-REQUEST' header in responses coming from WebDav server.
Added the 'requestId' information to exceptions to easier tracking the problem.