Skip to content

fix(bash): sed replacement escaping, BSD portability, dead cleanup in update-agent-context.sh #2090

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
mnriem merged 7 commits into from
Apr 8, 2026
+32 −16
Merged

fix(bash): sed replacement escaping, BSD portability, dead cleanup in update-agent-context.sh #2090

Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
8f97d7e
fix(bash): sed replacement escaping, BSD portability, dead cleanup code
Apr 4, 2026
1661ddb
fix: restore forge case and revert copilot path change
Apr 7, 2026
3280cd7
refactor: extract repeated sed escaping into _esc_sed helper
Apr 7, 2026
e4933f9
fix: restore combined AGENTS_FILE label in update_all_existing_agents
Apr 7, 2026
e26a1e6
fix: remove pre-escaped && in JS/TS commands now that _esc_sed handle…
Apr 7, 2026
414d016
fix: split awk && mv to let set -e catch awk failures
Apr 7, 2026
aac7864
fix: guard empty _CLEANUP_FILES array for Bash 3.2 compatibility
Apr 7, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
fix: guard empty _CLEANUP_FILES array for Bash 3.2 compatibility 
On Bash 3.2, the ${arr[@]+"${arr[@]}"} pattern expands to a single
empty string when the array is empty, causing rm to target .bak and
.tmp in the current directory. Use explicit length check instead,
which also avoids the word-splitting risk of unquoted expansion.

Co-Authored-By: Claude Opus 4.6 (1M context) <noreply@anthropic.com>
  • Loading branch information
@claude
Bo Bobson and claude committed Apr 7, 2026
commit aac7864734beea7dfe92c2408bd4ca825a1a4356
8 changes: 5 additions & 3 deletions scripts/bash/update-agent-context.sh
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -125,9 +125,11 @@ cleanup() {
local exit_code=$?
# Disarm traps to prevent re-entrant loop
trap - EXIT INT TERM
for f in "${_CLEANUP_FILES[@]+"${_CLEANUP_FILES[@]}"}"; do
rm -f "$f" "$f.bak" "$f.tmp"
done
if [ ${#_CLEANUP_FILES[@]} -gt 0 ]; then
for f in "${_CLEANUP_FILES[@]}"; do
rm -f "$f" "$f.bak" "$f.tmp"
done
fi
exit $exit_code
}

Expand Down
Loading