Skip to content

fix: Updates to add eslint10 to peer dependencies #702

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
CharlieM312 wants to merge 1 commit into
base: main
Choose a base branch
from
+606 −359
Open

fix: Updates to add eslint10 to peer dependencies #702

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion lib/configs/flat/recommended.js
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
import globals from 'globals'
import github from '../../plugin.js'
import prettierPlugin from 'eslint-plugin-prettier'
import eslintComments from 'eslint-plugin-eslint-comments'
import eslintComments from '@eslint-community/eslint-plugin-eslint-comments'
import importPlugin from 'eslint-plugin-import'
import i18nTextPlugin from 'eslint-plugin-i18n-text'
import noOnlyTestsPlugin from 'eslint-plugin-no-only-tests'
Expand Down
16 changes: 8 additions & 8 deletions lib/configs/recommended.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -8,16 +8,16 @@ export default {
env: {
es6: true,
},
plugins: ['github', 'prettier', 'eslint-comments', 'import', 'filenames', 'i18n-text', 'no-only-tests'],
plugins: ['github', 'prettier', '@eslint-community/eslint-plugin-eslint-comments', 'import', 'filenames', 'i18n-text', 'no-only-tests'],
rules: {
'constructor-super': 'error',
'eslint-comments/disable-enable-pair': 'off',
'eslint-comments/no-aggregating-enable': 'off',
'eslint-comments/no-duplicate-disable': 'error',
'eslint-comments/no-unlimited-disable': 'error',
'eslint-comments/no-unused-disable': 'error',
'eslint-comments/no-unused-enable': 'error',
'eslint-comments/no-use': ['error', {allow: ['eslint', 'eslint-disable-next-line', 'eslint-env', 'globals']}],
'@eslint-community/eslint-plugin-eslint-comments/disable-enable-pair': 'off',
'@eslint-community/eslint-plugin-eslint-comments/no-aggregating-enable': 'off',
'@eslint-community/eslint-plugin-eslint-comments/no-duplicate-disable': 'error',
'@eslint-community/eslint-plugin-eslint-comments/no-unlimited-disable': 'error',
'@eslint-community/eslint-plugin-eslint-comments/no-unused-disable': 'error',
'@eslint-community/eslint-plugin-eslint-comments/no-unused-enable': 'error',
'@eslint-community/eslint-plugin-eslint-comments/no-use': ['error', {allow: ['eslint', 'eslint-disable-next-line', 'eslint-env', 'globals']}],
Comment on lines +11 to +20
'filenames/match-regex': ['error', '^[a-z0-9-]+(.[a-z0-9-]+)?$'],
'func-style': ['error', 'declaration', {allowArrowFunctions: true}],
'github/array-foreach': 'error',
Expand Down
5 changes: 4 additions & 1 deletion lib/rules/get-attribute.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -12,7 +12,10 @@ const camelCaseAttributes = Object.values(svgElementAttributes)
const validSVGAttributeSet = new Set(camelCaseAttributes)

// lowercase variants of camelCase SVG attributes are probably an error
const invalidSVGAttributeSet = new Set(camelCaseAttributes.map(name => name.toLowerCase()))
const invalidSVGAttributeSet = new Set(camelCaseAttributes
.filter(name => typeof name === 'string')
.map(name => name.toLowerCase())
)
Comment on lines +16 to +18

function isValidAttribute(name) {
return validSVGAttributeSet.has(name) || (validAttributeName.test(name) && !invalidSVGAttributeSet.has(name))
Expand Down
Loading
Loading