fix: Updates to add eslint10 to peer dependencies#702
Open
CharlieM312 wants to merge 1 commit into
Open
Conversation
There was a problem hiding this comment.
Pull request overview
This PR updates the plugin package metadata and configuration to advertise compatibility with ESLint v10, alongside dependency upgrades and minor rule hardening to align with the newer ecosystem.
Changes:
- Widen
eslintpeerDependencies to include^10and bump related ecosystem dependencies. - Switch the eslint-comments plugin dependency to
@eslint-community/eslint-plugin-eslint-commentsand update configs accordingly. - Harden SVG attribute handling in
get-attributeby filtering non-string attribute entries before lowercasing.
Reviewed changes
Copilot reviewed 4 out of 5 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| package.json | Updates peer dependency range for ESLint v10 and bumps several dependencies/devDependencies. |
| package-lock.json | Lockfile updates reflecting dependency bumps and the new eslint-comments plugin package. |
| lib/rules/get-attribute.js | Avoids calling toLowerCase() on non-string SVG attribute entries. |
| lib/configs/recommended.js | Updates legacy config plugin/rule references for eslint-comments (currently incorrect). |
| lib/configs/flat/recommended.js | Switches flat config import to the new @eslint-community eslint-comments plugin package. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
Comment on lines
+11
to
+20
| plugins: ['github', 'prettier', '@eslint-community/eslint-plugin-eslint-comments', 'import', 'filenames', 'i18n-text', 'no-only-tests'], | ||
| rules: { | ||
| 'constructor-super': 'error', | ||
| 'eslint-comments/disable-enable-pair': 'off', | ||
| 'eslint-comments/no-aggregating-enable': 'off', | ||
| 'eslint-comments/no-duplicate-disable': 'error', | ||
| 'eslint-comments/no-unlimited-disable': 'error', | ||
| 'eslint-comments/no-unused-disable': 'error', | ||
| 'eslint-comments/no-unused-enable': 'error', | ||
| 'eslint-comments/no-use': ['error', {allow: ['eslint', 'eslint-disable-next-line', 'eslint-env', 'globals']}], | ||
| '@eslint-community/eslint-plugin-eslint-comments/disable-enable-pair': 'off', | ||
| '@eslint-community/eslint-plugin-eslint-comments/no-aggregating-enable': 'off', | ||
| '@eslint-community/eslint-plugin-eslint-comments/no-duplicate-disable': 'error', | ||
| '@eslint-community/eslint-plugin-eslint-comments/no-unlimited-disable': 'error', | ||
| '@eslint-community/eslint-plugin-eslint-comments/no-unused-disable': 'error', | ||
| '@eslint-community/eslint-plugin-eslint-comments/no-unused-enable': 'error', | ||
| '@eslint-community/eslint-plugin-eslint-comments/no-use': ['error', {allow: ['eslint', 'eslint-disable-next-line', 'eslint-env', 'globals']}], |
Comment on lines
+16
to
+18
| .filter(name => typeof name === 'string') | ||
| .map(name => name.toLowerCase()) | ||
| ) |
Comment on lines
61
to
63
| "peerDependencies": { | ||
| "eslint": "^8 || ^9" | ||
| "eslint": "^8 || ^9 || ^10" | ||
| }, |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Added eslint-10 to peer dependencies and updated the relevant rules based on the feedback I saw in #686
Let me know if this needs any additional changes to it, I believe the rules may need updating.
Also fixed an issue in get-attribute.js that was causing the eslint-check script to fail.