Skip to content

getPullRequestEditedDiffRanges: use GitHub API #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cklin merged 8 commits into from
Jan 14, 2025
Merged

getPullRequestEditedDiffRanges: use GitHub API #2679

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
68378a3
getPullRequestEditedDiffRanges: use GitHub API
cklin Jan 13, 2025
68b1b4e
getPullRequestEditedDiffRanges: compute diff ranges
cklin Jan 13, 2025
63d1f4f
getPullRequestEditedDiffRanges: check the number of changed files
cklin Jan 13, 2025
d4c56bb
getDiffRanges: improve handling for missing patch
cklin Jan 9, 2025
7848967
getDiffRanges: add unit tests
cklin Jan 13, 2025
52315a9
setupDiffInformedQueryRun: log setup failure
cklin Jan 9, 2025
3548ff5
writeDiffRangeDataExtensionPack: escape special characters in filenames
cklin Jan 10, 2025
ae19466
build: refresh js files
cklin Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
getDiffRanges: improve handling for missing patch
  • Loading branch information
@cklin
cklin committed Jan 13, 2025
commit d4c56bbb3164ea1d89016f186c62e78165624878
14 changes: 14 additions & 0 deletions src/analyze.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -375,6 +375,20 @@ function getDiffRanges(
logger: Logger,
): DiffThunkRange[] | undefined {
if (fileDiff.patch === undefined) {
if (fileDiff.changes === 0) {
// There are situations where a changed file legitimately has no diff.
// For example, the file may be a binary file, or that the file may have
// been renamed with no changes to its contents. In these cases, the
Comment thread
henrymercer marked this conversation as resolved.
// file would be reported as having 0 changes, and we can return an empty
// array to indicate no diff range in this file.
return [];
}
// If a file is reported to have nonzero changes but no patch, that may be
// due to the file diff being too large. In this case, we should return
// undefined to indicate that we cannot process the diff.
logger.warning(
`No patch found for file ${fileDiff.filename} with ${fileDiff.changes} changes.`,
);
return undefined;
}

Expand Down