Skip to content

getPullRequestEditedDiffRanges: use GitHub API #2679

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
cklin merged 8 commits into from
Jan 14, 2025
Merged

getPullRequestEditedDiffRanges: use GitHub API #2679

Changes from 1 commit
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
68378a3
getPullRequestEditedDiffRanges: use GitHub API
cklin Jan 13, 2025
68b1b4e
getPullRequestEditedDiffRanges: compute diff ranges
cklin Jan 13, 2025
63d1f4f
getPullRequestEditedDiffRanges: check the number of changed files
cklin Jan 13, 2025
d4c56bb
getDiffRanges: improve handling for missing patch
cklin Jan 9, 2025
7848967
getDiffRanges: add unit tests
cklin Jan 13, 2025
52315a9
setupDiffInformedQueryRun: log setup failure
cklin Jan 9, 2025
3548ff5
writeDiffRangeDataExtensionPack: escape special characters in filenames
cklin Jan 10, 2025
ae19466
build: refresh js files
cklin Jan 13, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
getPullRequestEditedDiffRanges: check the number of changed files
  • Loading branch information
@cklin
cklin committed Jan 13, 2025
commit 63d1f4f8a22a2a3f57e2bcdc94e4b61a02884c27
11 changes: 11 additions & 0 deletions src/analyze.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -298,6 +298,17 @@ async function getPullRequestEditedDiffRanges(
if (fileDiffs === undefined) {
return undefined;
}
if (fileDiffs.length >= 300) {
// The "compare two commits" API returns a maximum of 300 changed files. If
// we see that many changed files, it is possible that there could be more,
// with the rest being truncated. In this case, we should not attempt to
// compute the diff ranges, as the result would be incomplete.
logger.warning(
`Cannot retrieve the full diff because there are too many ` +
`(${fileDiffs.length}) changed files in the pull request.`,
);
return undefined;
}
const results: DiffThunkRange[] = [];
for (const filediff of fileDiffs) {
const diffRanges = getDiffRanges(filediff, logger);
Expand Down