Skip to content

Bump artifact dependencies if CODEQL_ACTION_ARTIFACT_V4_UPGRADE enabled #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelapwen merged 18 commits into from
Oct 1, 2024
Merged

Bump artifact dependencies if CODEQL_ACTION_ARTIFACT_V4_UPGRADE enabled #2482

Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
76b799d
Install `actions/artifact@v1` as `artifact-legacy` and `v2` as `artif…
angelapwen Sep 25, 2024
6d887c1
Update original import statements to use `artifact-legacy`
angelapwen Sep 25, 2024
4de3002
Use new artifact dependency if not on GHES & feature flag enabled
angelapwen Sep 25, 2024
35684ba
Add PR check with feature flag enabled to test upgrade
angelapwen Sep 25, 2024
4a5884a
Add changenote
angelapwen Sep 25, 2024
8e4d3c2
Refactor: remove argument array indirection and pass directly instead
angelapwen Sep 26, 2024
bca51cd
Rename feature flag to `CODEQL_ACTION_ARTIFACT_V2_UPGRADE`
angelapwen Sep 26, 2024
ce99e34
Add log messages at INFO level about which artifact version used
angelapwen Sep 26, 2024
0c5c594
Refactor: reuse `getArtifactUploaderClient` in `start-proxy-action`
angelapwen Sep 26, 2024
fbe39bd
Update changenote
angelapwen Sep 26, 2024
fd00289
Update checked-in dependencies
github-actions[bot] Sep 26, 2024
f52494d
Update CHANGELOG.md
angelapwen Sep 26, 2024
7c14037
Refer to `download-artifact@v4` everywhere to reduce confusion
angelapwen Sep 27, 2024
3788527
Merge remote-tracking branch 'origin' into angelapwen/upgrade-artifac…
angelapwen Sep 27, 2024
6b58e15
Update feature flag name
angelapwen Sep 30, 2024
d2642b6
Remove logging that mentions feature flags for clarity
angelapwen Sep 30, 2024
f29ffe2
Update CHANGELOG.md
angelapwen Sep 30, 2024
29620a0
Merge branch 'main' into angelapwen/bump-artifacts
angelapwen Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Update changenote
  • Loading branch information
@angelapwen
angelapwen committed Sep 26, 2024
commit fbe39bdbdf57b515ea29be5434deb8a197c5d5ef
7 changes: 3 additions & 4 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,10 +6,9 @@ Note that the only difference between `v2` and `v3` of the CodeQL Action is the

## [UNRELEASED]

- Add support for `@actions/artifact@v2` for uploading debug artifacts, for customers not running on GitHub Enterprise Server. [#2482](https://github.com/github/codeql-action/pull/2482)
- Only workflows that use `actions/download-artifact` to programmatically download the CodeQL Action debug artifacts will be affected: with the legacy artifact client, only `actions/download-artifact@v3` will be compatible. With the upgraded artifact client, only `actions/download-artifact@v4` will be compatible.
- To opt in to the upgraded artifact client, set the `CODEQL_ACTION_ARTIFACT_UPGRADE` environment variable to true and bump to `actions/download-artifact@v4`.
- All workflows that have not opted in by November 1 will be opted in by default. This is because `actions/upload-artifact@v3` and `actions/download-artifact@v3` will be deprecated at the end of November. See [GitHub Changelog](https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/).
- Add support for using `actions/download-artifact@v4` to programmatically consume CodeQL Action debug artifacts. Customers who use `actions/download-artifact` should set the `CODEQL_ACTION_ARTIFACT_UPGRADE` environment variable to true and bump `actions/download-artifact@v3` to `actions/download-artifact@v4` to avoid breakage. All customers, except those running on GitHub Enterprise Server, will be opted-in to this change in early November. [#2482](https://github.com/github/codeql-action/pull/2482)
Comment thread
angelapwen marked this conversation as resolved.
Outdated
- This is because `actions/upload-artifact@v3` and `actions/download-artifact@v3` will be deprecated at the end of November. See [GitHub Changelog](https://github.blog/changelog/2024-04-16-deprecation-notice-v3-of-the-artifact-actions/).
- This change is currently unavailable for GitHub Enterprise Server customers, as the compatible npm `@actions/artifact@v2` used to upload the artifacts is not yet supported on GHES.
Comment thread
angelapwen marked this conversation as resolved.
Outdated

## 3.26.9 - 24 Sep 2024

Expand Down