Skip to content

Bump artifact dependencies if CODEQL_ACTION_ARTIFACT_V4_UPGRADE enabled #2482

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
angelapwen merged 18 commits into from
Oct 1, 2024
Merged

Bump artifact dependencies if CODEQL_ACTION_ARTIFACT_V4_UPGRADE enabled #2482

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
18 commits
Select commit Hold shift + click to select a range
76b799d
Install `actions/artifact@v1` as `artifact-legacy` and `v2` as `artif…
angelapwen Sep 25, 2024
6d887c1
Update original import statements to use `artifact-legacy`
angelapwen Sep 25, 2024
4de3002
Use new artifact dependency if not on GHES & feature flag enabled
angelapwen Sep 25, 2024
35684ba
Add PR check with feature flag enabled to test upgrade
angelapwen Sep 25, 2024
4a5884a
Add changenote
angelapwen Sep 25, 2024
8e4d3c2
Refactor: remove argument array indirection and pass directly instead
angelapwen Sep 26, 2024
bca51cd
Rename feature flag to `CODEQL_ACTION_ARTIFACT_V2_UPGRADE`
angelapwen Sep 26, 2024
ce99e34
Add log messages at INFO level about which artifact version used
angelapwen Sep 26, 2024
0c5c594
Refactor: reuse `getArtifactUploaderClient` in `start-proxy-action`
angelapwen Sep 26, 2024
fbe39bd
Update changenote
angelapwen Sep 26, 2024
fd00289
Update checked-in dependencies
github-actions[bot] Sep 26, 2024
f52494d
Update CHANGELOG.md
angelapwen Sep 26, 2024
7c14037
Refer to `download-artifact@v4` everywhere to reduce confusion
angelapwen Sep 27, 2024
3788527
Merge remote-tracking branch 'origin' into angelapwen/upgrade-artifac…
angelapwen Sep 27, 2024
6b58e15
Update feature flag name
angelapwen Sep 30, 2024
d2642b6
Remove logging that mentions feature flags for clarity
angelapwen Sep 30, 2024
f29ffe2
Update CHANGELOG.md
angelapwen Sep 30, 2024
29620a0
Merge branch 'main' into angelapwen/bump-artifacts
angelapwen Oct 1, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Remove logging that mentions feature flags for clarity
  • Loading branch information
@angelapwen
angelapwen committed Sep 30, 2024
commit d2642b6711e9300bdd496c8894a8656150e8548d
2 changes: 1 addition & 1 deletion lib/debug-artifacts.js
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion lib/debug-artifacts.js.map
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion src/debug-artifacts.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,7 @@ export async function getArtifactUploaderClient(
return artifactLegacy.create();
} else if (!(await features.getValue(Feature.ArtifactV4Upgrade))) {
logger.info(
"Debug artifacts can be consumed with `actions/download-artifact@v3` because the value of the relevant feature flag is false. To use the `actions/download-artifact@v4`, set the `CODEQL_ACTION_ARTIFACT_V4_UPGRADE` environment variable to true.",
"Debug artifacts can be consumed with `actions/download-artifact@v3`. To use the `actions/download-artifact@v4`, set the `CODEQL_ACTION_ARTIFACT_V4_UPGRADE` environment variable to true.",
);
return artifactLegacy.create();
} else {
Expand Down