Skip to content

QL style guide: Small fixes#97

Merged
pavgust merged 1 commit into
github:masterfrom
shati-patel:ql-style-guide
Aug 29, 2018
Merged

QL style guide: Small fixes#97
pavgust merged 1 commit into
github:masterfrom
shati-patel:ql-style-guide

Conversation

@shati-patel
Copy link
Copy Markdown
Contributor

@shati-patel shati-patel commented Aug 23, 2018

  • Don't require new line after deprecated. This contradicts the example on line 275. (Or should we change the example? I don't know which is the more standard notation.)
  • Add a missing backtick.

- Don't suggest new line after `deprecated`
- Add a missing backtick
@shati-patel shati-patel requested a review from calumgrant August 23, 2018 14:20
@ghost
Copy link
Copy Markdown

ghost commented Aug 23, 2018

CLA assistant check
All committers have signed the CLA.

@aschackmull
Copy link
Copy Markdown
Contributor

No newline after deprecated seems slightly more common, although both styles appear to be used.

@shati-patel shati-patel removed the request for review from calumgrant August 29, 2018 15:00
@pavgust pavgust merged commit 4e3616e into github:master Aug 29, 2018
@shati-patel shati-patel deleted the ql-style-guide branch August 29, 2018 15:19
aibaars pushed a commit that referenced this pull request Oct 14, 2021
Categorize variable accesses into reads and (implicit or explicit) writes
smowton pushed a commit to smowton/codeql that referenced this pull request Dec 6, 2021
Kotlin: Show class name in log messages
erik-krogh pushed a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
erik-krogh pushed a commit to erik-krogh/ql that referenced this pull request Dec 15, 2021
dbartol pushed a commit that referenced this pull request Dec 18, 2024
…ction-alerts

Suppress `actions/cache-poisoning/code-injection` alerts covered by `actions/code-injection/critical`
MathiasVP added a commit to MathiasVP/ql that referenced this pull request Aug 10, 2025
…into-dataflow

PS: Integrate SSA computations into dataflow
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants