C#: Fix @kind property of CCyclomaticComplexity#87
Merged
Conversation
The Metrics folder has a queries.xml file which is required when building a full distribution, as the Metrics folder gets copied into odasa-csharp-metrics directory. However, in QL for Eclipse this doesn't compile because it prevents import lookup at the top level. Modifying the qlpath file to include the top-level directory on the library path fixes the problem.
hvitved
approved these changes
Aug 21, 2018
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Dec 6, 2021
Add optional compilation start plugin option + remove exitProcess
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
New query: Unnecessary 'exists'
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
QL: Respond to PR reviews for github#87
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
…ists New query: Unnecessary 'exists'
erik-krogh
pushed a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
…akes QL: Respond to PR reviews for github#87
dbartol
pushed a commit
that referenced
this pull request
Dec 18, 2024
Consider a Reusable Workflow privileged if a caller is
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
…-query PS: Port `powershell/command-injection` from the internal repo
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The
CCyclomaticComplexitty.qlquery has the wrong@kind- it is a metric query, so needs@kind treemapinstead of@kind table.In fixing this problem, I noticed that queries in the
Metricsquery directory do not compile in QL for Eclipse. This is because theMetricsdirectory has aqueries.xmlfile which prevents import resolution for the top-level project directory. This has been solved by setting the appropriate library path in the.qlpathfile, which is the same solution used bysemmlecode-cpp-queries.