C#: Remove some unused legacy relations from the DB scheme#7746
Merged
Conversation
Contributor
|
Looks good to me! Did you manually change the stats file and should we consider run (1) DCA stat generation (2) DCA performance test |
michaelnebel
approved these changes
Jan 26, 2022
Contributor
michaelnebel
left a comment
There was a problem hiding this comment.
Excellent to eliminate dead stuff!
Contributor
Author
I manually deleted the entries for the deleted relations. A DCA performance test should not be needed, as these stats only pertained to relations that are not used in any queries. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Remove the following legacy relations:
externalDefectsexternalMetricsexternalDatasnapshotDateduplicateCodesimilarCodetokens.rel