Skip to content

C#: Remove some unused legacy relations from the DB scheme#7746

Merged
hvitved merged 3 commits into
github:mainfrom
hvitved:csharp/remove-legacy-relations
Jan 26, 2022
Merged

C#: Remove some unused legacy relations from the DB scheme#7746
hvitved merged 3 commits into
github:mainfrom
hvitved:csharp/remove-legacy-relations

Conversation

@hvitved
Copy link
Copy Markdown
Contributor

@hvitved hvitved commented Jan 26, 2022

Remove the following legacy relations:

  • externalDefects
  • externalMetrics
  • externalData
  • snapshotDate
  • duplicateCode
  • similarCode
  • tokens.rel

@github-actions github-actions Bot added the C# label Jan 26, 2022
@hvitved hvitved marked this pull request as ready for review January 26, 2022 08:48
@hvitved hvitved requested a review from a team as a code owner January 26, 2022 08:48
@michaelnebel michaelnebel self-requested a review January 26, 2022 08:52
@michaelnebel
Copy link
Copy Markdown
Contributor

Looks good to me! Did you manually change the stats file and should we consider run (1) DCA stat generation (2) DCA performance test

Copy link
Copy Markdown
Contributor

@michaelnebel michaelnebel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent to eliminate dead stuff!

@hvitved
Copy link
Copy Markdown
Contributor Author

hvitved commented Jan 26, 2022

Did you manually change the stats file and should we consider run (1) DCA stat generation (2) DCA performance test

I manually deleted the entries for the deleted relations. A DCA performance test should not be needed, as these stats only pertained to relations that are not used in any queries.

@hvitved hvitved merged commit 477f83c into github:main Jan 26, 2022
@hvitved hvitved deleted the csharp/remove-legacy-relations branch January 26, 2022 09:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants