Skip to content

Master-to-next merge#723

Merged
xiemaisi merged 100 commits into
nextfrom
qlucie/master
Jan 7, 2019
Merged

Master-to-next merge#723
xiemaisi merged 100 commits into
nextfrom
qlucie/master

Conversation

@semmle-qlci
Copy link
Copy Markdown
Contributor

Automatically created merge PR, pulling recent master changes into next.

hvitved and others added 30 commits December 7, 2018 12:03
…::controlsBlock()`

Only calculate dominance by explicit recursion for split nodes; all other nodes
can use regular CFG dominance.
Refactored to make it clear when `@operator.Symbol as IMethodSymbol` can be `null`.
Factor `ClauseCall` out into three classes to make it clear when the fields
`operand` and `declaration` can be `null`.
Using the `forceCachingInSameStage()` trick, we can get rid of the non-cached version
of local flow, while still computing it in the same stage.
…brary

Computing strings and locations for CIL instructions can be quite time consuming.
The CIL `toString()`s are not very helpful in path explanations, and their locations
are only useful when a PDB source file exists. Therefore, produce a simple constant
`toString()`, and restrict locations to those in PDB files.
As described on https://lgtm.com/help/ql/locations#providing-location-information,
there is no need to provide a `getUrl()` predicate, when there is a `getLocation()`
predicate. Not only is it redundant, but it can also be slow because of string
construction.
…orings

C#: nullness related extractor refactorings
C#: Cache `NamedElement::getLabel()`
semmle-qlci and others added 4 commits January 3, 2019 17:59
Java: Add missing override annotations.
CPP: Improve qldoc for MacroAccess and MacroInvocation.
@semmle-qlci semmle-qlci requested review from a team as code owners January 4, 2019 09:57
xiemaisi
xiemaisi previously approved these changes Jan 4, 2019
@pavgust
Copy link
Copy Markdown
Contributor

pavgust commented Jan 4, 2019

This pull request introduces 1 alert when merging 79e246f into 6b27dca - view on LGTM.com

new alerts:

  • 1 for Redundant ToString() call

Comment posted by LGTM.com

jbj
jbj previously approved these changes Jan 4, 2019
hvitved
hvitved previously approved these changes Jan 4, 2019
@jbj
Copy link
Copy Markdown
Contributor

jbj commented Jan 4, 2019

Why is there no Language-Tests/JavaScript running?

@pavgust
Copy link
Copy Markdown
Contributor

pavgust commented Jan 4, 2019

This pull request introduces 1 alert when merging b4f400f into 6b27dca - view on LGTM.com

new alerts:

  • 1 for Redundant ToString() call

Comment posted by LGTM.com

yh-semmle
yh-semmle previously approved these changes Jan 4, 2019
@calumgrant
Copy link
Copy Markdown
Contributor

calumgrant commented Jan 4, 2019

Unfortunately, the C# tests will fail until #725 is merged.

@pavgust pavgust dismissed stale reviews from yh-semmle, hvitved, jbj, and xiemaisi via 42cf760 January 4, 2019 18:24
@pavgust pavgust mentioned this pull request Jan 4, 2019
@pavgust
Copy link
Copy Markdown
Contributor

pavgust commented Jan 4, 2019

This pull request introduces 1 alert when merging 42cf760 into 6b27dca - view on LGTM.com

new alerts:

  • 1 for Redundant ToString() call

Comment posted by LGTM.com

@xiemaisi
Copy link
Copy Markdown

xiemaisi commented Jan 7, 2019

C++ and C# tests have passed, JavaScript tests passed previously and nothing relevant has changed in the meantime, so merging.

@xiemaisi xiemaisi merged commit aa6b89d into next Jan 7, 2019
@xiemaisi xiemaisi deleted the qlucie/master branch June 3, 2019 07:50
cklin pushed a commit that referenced this pull request Apr 26, 2022
Release preparation for version 2.9.0
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

10 participants