Master-to-next merge#723
Merged
Merged
Conversation
…::controlsBlock()` Only calculate dominance by explicit recursion for split nodes; all other nodes can use regular CFG dominance.
Refactored to make it clear when `@operator.Symbol as IMethodSymbol` can be `null`.
…ion are declared before they are used.
Factor `ClauseCall` out into three classes to make it clear when the fields `operand` and `declaration` can be `null`.
Using the `forceCachingInSameStage()` trick, we can get rid of the non-cached version of local flow, while still computing it in the same stage.
…brary Computing strings and locations for CIL instructions can be quite time consuming. The CIL `toString()`s are not very helpful in path explanations, and their locations are only useful when a PDB source file exists. Therefore, produce a simple constant `toString()`, and restrict locations to those in PDB files.
As described on https://lgtm.com/help/ql/locations#providing-location-information, there is no need to provide a `getUrl()` predicate, when there is a `getLocation()` predicate. Not only is it redundant, but it can also be slow because of string construction.
…orings C#: nullness related extractor refactorings
C#: Cache `NamedElement::getLabel()`
Approved by calumgrant
Java: Add missing override annotations.
Java: Remove `Metrics/queries.xml`
CPP: Improve qldoc for MacroAccess and MacroInvocation.
xiemaisi
previously approved these changes
Jan 4, 2019
Contributor
|
This pull request introduces 1 alert when merging 79e246f into 6b27dca - view on LGTM.com new alerts:
Comment posted by LGTM.com |
jbj
previously approved these changes
Jan 4, 2019
hvitved
previously approved these changes
Jan 4, 2019
Contributor
|
Why is there no Language-Tests/JavaScript running? |
Contributor
|
This pull request introduces 1 alert when merging b4f400f into 6b27dca - view on LGTM.com new alerts:
Comment posted by LGTM.com |
yh-semmle
previously approved these changes
Jan 4, 2019
Contributor
|
Unfortunately, the C# tests will fail until #725 is merged. |
Closed
Contributor
|
This pull request introduces 1 alert when merging 42cf760 into 6b27dca - view on LGTM.com new alerts:
Comment posted by LGTM.com |
xiemaisi
approved these changes
Jan 7, 2019
|
C++ and C# tests have passed, JavaScript tests passed previously and nothing relevant has changed in the meantime, so merging. |
cklin
pushed a commit
that referenced
this pull request
Apr 26, 2022
Release preparation for version 2.9.0
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Automatically created merge PR, pulling recent
masterchanges intonext.