C#: Account for CFG splitting in AssignableDefinition::getAFirstRead() and AssignableRead::getANextRead()#708
Merged
Conversation
8cd855b to
7172e62
Compare
Contributor
Author
|
Rebased to resolve merge conflict in |
calumgrant
suggested changes
Dec 31, 2018
Contributor
calumgrant
left a comment
There was a problem hiding this comment.
One minor change, otherwise LGTM.
| cfn = result.getAControlFlowNode() | | ||
| exists(Ssa::ExplicitDefinition def | | ||
| result = def.getAFirstReadAtNode(cfn) | | ||
| this = def.(Ssa::ExplicitDefinition).getADefinition() |
Contributor
There was a problem hiding this comment.
This cast is redundant?
…()` and `AssignableRead::getANextRead()`
7172e62 to
2427f0a
Compare
Contributor
Author
|
Rebased to resolve merge conflict in |
calumgrant
approved these changes
Jan 3, 2019
hmlendea
added a commit
to hmlendea/steam-key-activator
that referenced
this pull request
Nov 19, 2021
until it supports .NET 6.0 (github/codeql#708)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.