Skip to content

Java: Promote Insecure TrustManager from experimental #7136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atorralba merged 7 commits into from
Jan 24, 2022
Merged

Java: Promote Insecure TrustManager from experimental #7136

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7cd05fb
Move from experimental
atorralba Nov 12, 2021
ab4dc30
Refactor into libraries
atorralba Nov 12, 2021
d58bb47
Refactor tests
atorralba Nov 12, 2021
77c2b43
Add change note and severity score
atorralba Nov 15, 2021
7a1a45f
QLDoc
atorralba Nov 15, 2021
c105d71
Update InsecureTrustManager.qhelp
mchammer01 Nov 22, 2021
967308f
Change InsecureTrustManagerConfiguration to DataFlow
atorralba Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Next Next commit
Refactor tests
  • Loading branch information
@atorralba
atorralba committed Jan 20, 2022
commit d58bb4753e4ec834d7fdb7444596b1474916eb92
2 changes: 1 addition & 1 deletion java/ql/src/Security/CWE/CWE-295/InsecureTrustManager.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -16,5 +16,5 @@ import DataFlow::PathGraph

from DataFlow::PathNode source, DataFlow::PathNode sink
where any(InsecureTrustManagerConfiguration cfg).hasFlowPath(source, sink)
select sink, source, sink, "This $@, that is defined $@, trusts any certificate and is used here.",
select sink, source, sink, "This $@, which is defined $@ and trusts any certificate, is used here.",
source, "TrustManager", source.getNode().asExpr().(ClassInstanceExpr).getConstructedType(), "here"
94 changes: 0 additions & 94 deletions java/ql/test/query-tests/security/CWE-295/InsecureTrustManager/InsecureTrustManager.expected
View file
Open in desktop

This file was deleted.

1 change: 0 additions & 1 deletion java/ql/test/query-tests/security/CWE-295/InsecureTrustManager/InsecureTrustManager.qlref
View file
Open in desktop

This file was deleted.

Empty file added .../test/query-tests/security/CWE-295/InsecureTrustManager/InsecureTrustManagerTest.expected
View file
Open in desktop
Empty file.
Loading