Skip to content

Java: Promote Insecure TrustManager from experimental #7136

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
atorralba merged 7 commits into from
Jan 24, 2022
Merged

Java: Promote Insecure TrustManager from experimental #7136

Show file tree
Hide file tree
Changes from 1 commit
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
7cd05fb
Move from experimental
atorralba Nov 12, 2021
ab4dc30
Refactor into libraries
atorralba Nov 12, 2021
d58bb47
Refactor tests
atorralba Nov 12, 2021
77c2b43
Add change note and severity score
atorralba Nov 15, 2021
7a1a45f
QLDoc
atorralba Nov 15, 2021
c105d71
Update InsecureTrustManager.qhelp
mchammer01 Nov 22, 2021
967308f
Change InsecureTrustManagerConfiguration to DataFlow
atorralba Jan 20, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Prev Previous commit
Change InsecureTrustManagerConfiguration to DataFlow
  • Loading branch information
@atorralba
atorralba committed Jan 20, 2022
commit 967308fbfda50db4ec66634b82258828bb539461
9 changes: 7 additions & 2 deletions java/ql/lib/semmle/code/java/security/InsecureTrustManagerQuery.qll
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,19 +2,24 @@

import java
import semmle.code.java.dataflow.FlowSources
import semmle.code.java.security.Encryption
import semmle.code.java.security.InsecureTrustManager

/**
* A configuration to model the flow of an insecure `TrustManager`
* to the initialization of an SSL context.
*/
class InsecureTrustManagerConfiguration extends TaintTracking::Configuration {
class InsecureTrustManagerConfiguration extends DataFlow::Configuration {
InsecureTrustManagerConfiguration() { this = "InsecureTrustManagerConfiguration" }

override predicate isSource(DataFlow::Node source) {
source instanceof InsecureTrustManagerSource
}

override predicate isSink(DataFlow::Node sink) { sink instanceof InsecureTrustManagerSink }

override predicate allowImplicitRead(DataFlow::Node node, DataFlow::Content c) {
(this.isSink(node) or this.isAdditionalFlowStep(node, _)) and
node.getType() instanceof Array and
c instanceof DataFlow::ArrayContent
}
}
30 changes: 15 additions & 15 deletions java/ql/test/query-tests/security/CWE-295/InsecureTrustManager/InsecureTrustManagerTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -121,7 +121,7 @@ private static void directInsecureTrustManagerCall()
throws NoSuchAlgorithmException, KeyManagementException {
SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow
}

private static void namedVariableFlagDirectInsecureTrustManagerCall()
Expand All @@ -145,7 +145,7 @@ private static void noNamedVariableFlagDirectInsecureTrustManagerCall()
if (SOME_NAME_THAT_IS_NOT_A_FLAG_NAME) {
SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow
}
}

Expand Down Expand Up @@ -177,7 +177,7 @@ private static void noStringLiteralFlagDirectInsecureTrustManagerCall()
if (Boolean.parseBoolean(System.getProperty("SOME_NAME_THAT_IS_NOT_A_FLAG_NAME"))) {
SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow
}
}

Expand Down Expand Up @@ -209,7 +209,7 @@ private static void noMethodAccessFlagDirectInsecureTrustManagerCall()
if (is42TheAnswerForEverything()) {
SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow
}
}

Expand All @@ -226,7 +226,7 @@ private static void isEqualsIgnoreCaseDirectInsecureTrustManagerCall()
if (schemaFromHttpRequest.equalsIgnoreCase("https")) {
SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow
}
}

Expand All @@ -244,7 +244,7 @@ private static void noIsEqualsIgnoreCaseDirectInsecureTrustManagerCall()
if (!schemaFromHttpRequest.equalsIgnoreCase("https")) {
SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow
}
}

Expand All @@ -264,7 +264,7 @@ private static void namedVariableFlagNOTGuardingDirectInsecureTrustManagerCall()

SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow

}

Expand All @@ -276,7 +276,7 @@ private static void noNamedVariableFlagNOTGuardingDirectInsecureTrustManagerCall

SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow

}

Expand All @@ -288,7 +288,7 @@ private static void stringLiteralFlagNOTGuardingDirectInsecureTrustManagerCall()

SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow

}

Expand All @@ -300,7 +300,7 @@ private static void noStringLiteralFlagNOTGuardingDirectInsecureTrustManagerCall

SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow

}

Expand All @@ -312,7 +312,7 @@ private static void methodAccessFlagNOTGuardingDirectInsecureTrustManagerCall()

SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow

}

Expand All @@ -324,7 +324,7 @@ private static void noMethodAccessFlagNOTGuardingDirectInsecureTrustManagerCall(

SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow
}

private static void isEqualsIgnoreCaseNOTGuardingDirectInsecureTrustManagerCall()
Expand All @@ -336,7 +336,7 @@ private static void isEqualsIgnoreCaseNOTGuardingDirectInsecureTrustManagerCall(

SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow

}

Expand All @@ -349,14 +349,14 @@ private static void noIsEqualsIgnoreCaseNOTGuardingDirectInsecureTrustManagerCal

SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow

}

private static void disableTrustManager()
throws NoSuchAlgorithmException, KeyManagementException {
SSLContext context = SSLContext.getInstance("TLS");
TrustManager[] trustManager = new TrustManager[] {new InsecureTrustManager()};
context.init(null, trustManager, null); // $ hasTaintFlow
context.init(null, trustManager, null); // $ hasValueFlow
}
}
4 changes: 1 addition & 3 deletions java/ql/test/query-tests/security/CWE-295/InsecureTrustManager/InsecureTrustManagerTest.ql
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -3,9 +3,7 @@ import semmle.code.java.security.InsecureTrustManagerQuery
import TestUtilities.InlineFlowTest

class InsecureTrustManagerTest extends InlineFlowTest {
override DataFlow::Configuration getValueFlowConfig() { none() }

override TaintTracking::Configuration getTaintFlowConfig() {
override DataFlow::Configuration getValueFlowConfig() {
result = any(InsecureTrustManagerConfiguration c)
}
}