Skip to content

Python: Expand test of py/use-of-input #5933

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
tausbn merged 1 commit into from
May 31, 2021
Merged

Python: Expand test of py/use-of-input #5933

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion python/ql/test/2/query-tests/Expressions/UseofApply.expected
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,2 +1,2 @@
| UseofApply.py:19:3:19:17 | ControlFlowNode for apply() | Call to the obsolete builtin function 'apply'. |
| expressions_test.py:3:5:3:21 | ControlFlowNode for apply() | Call to the obsolete builtin function 'apply'. |
| expressions_test.py:2:5:2:21 | ControlFlowNode for apply() | Call to the obsolete builtin function 'apply'. |
15 changes: 13 additions & 2 deletions python/ql/test/2/query-tests/Expressions/expressions_test.py
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,7 +1,18 @@

def use_of_apply(func, args):
apply(func, args)


def use_of_input():
return input()
return input() # NOT OK


def not_use_of_input():
input = raw_input
return input() # OK


if __name__ == "__main__":
# if you enter 4+4 each time, you'll see that results are: 8, '4+4', 8
print("result:", use_of_input())
print("result:", not_use_of_input())
print("result:", use_of_input())

@tausbn tausbn May 31, 2021

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, I was like "why test this again?", but I'm guessing now that this is to test that input is unaffected by the call to not_use_of_input.