Skip to content

Python: Expand test of py/use-of-input - #5933

Merged
tausbn merged 1 commit into
github:mainfrom
RasmusWL:expand-use-of-input-test
May 31, 2021
Merged

Python: Expand test of py/use-of-input#5933
tausbn merged 1 commit into
github:mainfrom
RasmusWL:expand-use-of-input-test

Conversation

@RasmusWL

@RasmusWL RasmusWL commented May 20, 2021

Copy link
Copy Markdown
Member

I had these expanded tests lying around. I thought they were useful to see that the porting of the query from #5880 does actually handle the case of input = raw_input 👍

@RasmusWL RasmusWL added the no-change-note-required This PR does not need a change note label May 20, 2021
@RasmusWL
RasmusWL requested a review from a team as a code owner May 20, 2021 12:53

@tausbn tausbn left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me. 👍

# if you enter 4+4 each time, you'll see that results are: 8, '4+4', 8
print("result:", use_of_input())
print("result:", not_use_of_input())
print("result:", use_of_input())

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

At first, I was like "why test this again?", but I'm guessing now that this is to test that input is unaffected by the call to not_use_of_input.

@tausbn
tausbn merged commit d9911a0 into github:main May 31, 2021
@RasmusWL
RasmusWL deleted the expand-use-of-input-test branch May 31, 2021 09:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

no-change-note-required This PR does not need a change note Python

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants