Skip to content

C#: Extensions to pre-SSA library - #489

Merged
calumgrant merged 2 commits into
github:masterfrom
hvitved:csharp/pre-ssa-extensions
Nov 20, 2018
Merged

C#: Extensions to pre-SSA library#489
calumgrant merged 2 commits into
github:masterfrom
hvitved:csharp/pre-ssa-extensions

Conversation

@hvitved

@hvitved hvitved commented Nov 19, 2018

Copy link
Copy Markdown
Contributor

Extend the pre-SSA library with computation of phi inputs, and include fields/properties that behave like local scope variables. This is in preparation for an upcoming PR that improves the nullness queries.

This PR builds on #449, so only the last two commits need reviewing.

@calumgrant

@hvitved hvitved added the C# label Nov 19, 2018
@hvitved
hvitved requested a review from calumgrant November 19, 2018 12:00
@hvitved
hvitved requested a review from a team as a code owner November 19, 2018 12:00

@calumgrant calumgrant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall LGTM.

Comment thread csharp/ql/test/library-tests/dataflow/ssa/PreSsaConsistency.ql Outdated
@hvitved
hvitved force-pushed the csharp/pre-ssa-extensions branch from e4845da to 3e78c26 Compare November 20, 2018 14:08
@hvitved

hvitved commented Nov 20, 2018

Copy link
Copy Markdown
Contributor Author

Rebased to resolve merge conflict.

@calumgrant
calumgrant merged commit 87072df into github:master Nov 20, 2018
@hvitved
hvitved deleted the csharp/pre-ssa-extensions branch November 20, 2018 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants