Skip to content

C#: Fix two bugs in Boolean CFG splitting - #491

Merged
calumgrant merged 3 commits into
github:masterfrom
hvitved:csharp/cfg/split-negation
Nov 21, 2018
Merged

C#: Fix two bugs in Boolean CFG splitting#491
calumgrant merged 3 commits into
github:masterfrom
hvitved:csharp/cfg/split-negation

Conversation

@hvitved

@hvitved hvitved commented Nov 19, 2018

Copy link
Copy Markdown
Contributor

This PR is based on #489, so only the last three commits need reviewing.

@calumgrant

@hvitved hvitved added the C# label Nov 19, 2018
@hvitved
hvitved requested a review from calumgrant November 19, 2018 12:29
@hvitved
hvitved requested a review from a team as a code owner November 19, 2018 12:29
@hvitved
hvitved force-pushed the csharp/cfg/split-negation branch from 8d13357 to 80affd3 Compare November 20, 2018 14:10
This test exhibits two issues with Boolean CFG splitting: incorrect handling of
negated variables and incorrect splitting for variables defined inside a loop.
@hvitved
hvitved force-pushed the csharp/cfg/split-negation branch from 80affd3 to 8233e34 Compare November 20, 2018 20:23

@calumgrant calumgrant left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@calumgrant
calumgrant merged commit 1b12e84 into github:master Nov 21, 2018
@hvitved
hvitved deleted the csharp/cfg/split-negation branch November 21, 2018 12:02
cklin pushed a commit that referenced this pull request May 23, 2022
Actions: Add workflow to request docs review
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants