Java: add previous-id and change 'use' to 'call'

github · jcogs33 · Apr 22, 2025 · Mar 20, 2025 · Mar 20, 2025 · Mar 20, 2025
commit f73eda0c38ab9c02407d9d2f1ce380d42a653401
@@ -1,6 +1,7 @@
 /**
- * @id java/do-not-use-finalize
- * @name Do not use `finalize`
+ * @id java/do-not-call-finalize
+ * @previous-id java/do-not-use-finalizers
+ * @name Do not call `finalize`
  * @description Calling `finalize` in application code may cause
  *              inconsistent program state or unpredicatable behavior.
  * @kind problem

diff --git a/java/ql/src/change-notes/2025-03-20-do-not-call-finalize.md b/java/ql/src/change-notes/2025-03-20-do-not-call-finalize.md
@@ -0,0 +1,4 @@
+---
+category: newQuery
+---
+* Added a new quality query, `java/do-not-call-finalize`, to detect calls to `finalize`.
diff --git a/java/ql/src/change-notes/2025-03-20-do-not-use-finalize.md b/java/ql/src/change-notes/2025-03-20-do-not-use-finalize.md
@@ -0,0 +1,2 @@
+query: Violations of Best Practice/Undesirable Calls/DoNotCallFinalize.ql
+postprocess: utils/test/InlineExpectationsTestQuery.ql
diff --git a/java/ql/test/query-tests/DoNotUseFinalize/DoNotUseFinalize.qlref b/java/ql/test/query-tests/DoNotUseFinalize/DoNotUseFinalize.qlref
Original file line number	Diff line number	Diff line change
		@@ -0,0 +1,2 @@
		query: Violations of Best Practice/Undesirable Calls/DoNotCallFinalize.ql
		postprocess: utils/test/InlineExpectationsTestQuery.ql