Java: add more test cases

github · jcogs33 · Apr 22, 2025 · Mar 20, 2025 · Mar 20, 2025 · Mar 20, 2025
commit c689a0e9b718ff14fd5923e25c0b57224badf64b
diff --git a/java/ql/test/query-tests/DoNotUseFinalize/DoNotUseFinalize.expected b/java/ql/test/query-tests/DoNotUseFinalize/DoNotUseFinalize.expected
@@ -1 +1,2 @@
-| Test.java:3:9:3:23 | finalize(...) | Call to 'finalize'. |
+| Test.java:4:9:4:23 | finalize(...) | Call to 'finalize'. |
+| Test.java:25:9:25:33 | finalize(...) | Call to 'finalize'. |
diff --git a/java/ql/test/query-tests/DoNotUseFinalize/Test.java b/java/ql/test/query-tests/DoNotUseFinalize/Test.java
@@ -7,4 +7,22 @@ void f() throws Throwable {
     void f1() throws Throwable {
         f(); // COMPLIANT
     }
+
+    @Override
+    protected void finalize() throws Throwable {
+        // COMPLIANT: If a subclass overrides `finalize`
+        // it must invoke the superclass finalizer explicitly.
+        super.finalize();
+    }
+
+    // Overload of `finalize`
+    protected void finalize(String s) throws Throwable {
+        System.out.println(s);
+    }
+
+    // NON_COMPLIANT: call to overload of `finalize`
+    void f2() throws Throwable {
+        this.finalize("overload"); // $ Alert
+    }
+
 }