C++: Improve GlobalNamespace.getADeclaration()#144
Merged
Conversation
jbj
previously approved these changes
Sep 4, 2018
Contributor
jbj
left a comment
There was a problem hiding this comment.
LGTM. I can merge when the merge conflict is resolved.
Globals can still have declarations in declaration statements. We already rule out local variables etc via the isTopLevel check, so we don't need to consider DeclStmt.
db341cb to
3fd6a8d
Compare
Contributor
Author
|
Rebased. |
jbj
approved these changes
Sep 4, 2018
aibaars
added a commit
that referenced
this pull request
Oct 14, 2021
AST: add missing getAPrimaryQlClass predicate
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Jan 17, 2022
Extract function expressions
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Globals can still have declarations in declaration statements. We already rule out local variables etc via the
isTopLevelcheck, so we don't need to considerDeclStmt.This is on top of #138.