C++: Use Declaration.isTopLevel() in GlobalNamespace.getADeclaration()#138
Merged
Conversation
jbj
approved these changes
Sep 4, 2018
Contributor
jbj
left a comment
There was a problem hiding this comment.
I tested this on a C++ snapshot, and the only difference I saw was that friend declarations went away. That seems right.
smowton
pushed a commit
to smowton/codeql
that referenced
this pull request
Dec 6, 2021
Kotlin: CFG improvements, and consistency check
erik-krogh
added a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
bump the severity of `ql/implicit-this`
erik-krogh
added a commit
to erik-krogh/ql
that referenced
this pull request
Dec 15, 2021
bump the severity of `ql/implicit-this`
MathiasVP
added a commit
to MathiasVP/ql
that referenced
this pull request
Aug 10, 2025
…nd-query PS: Add the first non-experimental query
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This additionally rules out
UserType.isLocaland friend declarations, but that sounds correct to me.