JS: Fix performance regression in the GetLaterAccess module.#12592
Merged
Conversation
e148214 to
02c0cd1
Compare
asgerf
reviewed
Mar 22, 2023
asgerf
left a comment
Contributor
There was a problem hiding this comment.
One minor nit, otherwise LGTM. Though it would be nice if we could somehow verify that it actually fixes the observed problem
Co-authored-by: Asger F <asgerf@github.com>
asgerf
approved these changes
Mar 22, 2023
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Both motivated by a previous dist-upgrade, and github/codeql-action#1568 (which I think has the same issue).
1: Use SSA, that fixed the join-order.
2: Fix the join-order of the fix, because other cases started to regress.
It now performs well on all benchmarks I've tried (I don't have access to the database used in github/codeql-action#1568).
A MRVA run with the top 1000 projects finished in 25 minutes when running
js/xss.An evaluation was uneventful.
A previous attempt of doing the same thing can be found here: #12105