Skip to content

JS: use SSA in the GetLaterAccess module#12105

Closed
erik-krogh wants to merge 1 commit into
github:mainfrom
erik-krogh:varAccessSsa
Closed

JS: use SSA in the GetLaterAccess module#12105
erik-krogh wants to merge 1 commit into
github:mainfrom
erik-krogh:varAccessSsa

Conversation

@erik-krogh

@erik-krogh erik-krogh commented Feb 6, 2023

Copy link
Copy Markdown
Contributor

Fixes a worst-case behavior in the getLaterBaseAccess predicate by using SSA variables.

Gets the worstcase performance down from 20 minutes (on my laptop), down to milliseconds.
It was causing timeouts on some smaller runners.

Also somehow fixed a missing result that I apparently missed when I first implemented GetLaterAccess 🤷

TODO: Evaluations: nightly, problematic, default.

Problematic project:

metafloor/bwip-js (regress with SSA)
varemenos/codemagic (regress with SSA, smaller)
aakashjhawar/commercial-centers-using-POI (regress before SSA)

@github-actions github-actions Bot added the JS label Feb 6, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant