CPP: Revert recent microsoft detection change#1216
Conversation
|
I've figured out that, in the ChakraCore snapshot in question, some compilations do and some do not include a reference to |
jbj
left a comment
There was a problem hiding this comment.
I'm curious what the command lines without cl.exe look like. Anyway, let's merge this as a first step, and then we can take a bit longer to understand the problem and test the proper fix.
|
They look something like this (comma-separated arguments): I'm working on a PR that will fix this by only caring whether any file in the snapshot contained |
|
That sounds reasonable. |
Reverts #1191.
This will re-introduce the 239 WrongTypeFormatArgument FPs on ChakraCore on the differences job - but fix the Windows tests.
Annoyingly I can't actually find a snapshot where the original problem (failing to detect that files in a ChakraCore snapshot are built as Microsoft) actually occurs. With such a snapshot I could analyse exactly the clues that are present and possibly develop a better solution.