CPP: Workaround improvement for File.compiledAsMicrosoft.#1191
Conversation
|
I know I'm the one who suggested this, but I feel bad about it already. As a workaround, it might do for now. We should also support network paths like |
Yes, as you said, it's a workaround - and I'm hoping we can get extractor support to replace this in the not too distant future. @ian-semmle please could we turn this into a planned task if we haven't done so already?
If you're happy that there are no Unix absolute paths that don't begin without a |
|
It turns out that I think it'll definitely be a Windows file system if the second character is |
I actually ran a similar query with just the case for |
|
(done) |
This will fix the 239 new results (in chakracore) on the internal CPP differences dashboard that showed up due to failing to correctly identify a Microsoft context. The fix is a heuristic, in the long run we need to make the extractor changes that were talked about a week or so ago.
Does not affect LGTM.