Swift: db up/downgrade scripts#11205
Conversation
3df915d to
abd11e8
Compare
redsun82
left a comment
There was a problem hiding this comment.
This is inspired by the ruby checks.
The scripts check is running on macOS since the first command yields no results and breaks the whole invocation. Perhaps, xargs works differently on macOS and Linux?
codeql resolve upgrades --format=lines --allow-downgrades --additional-packs downgrades \ --dbscheme=ql/lib/swift.dbscheme --target-dbscheme=downgrades/initial/swift.dbscheme | xargs codeql execute upgrades testdb
I think the problem is the behaviour of xargs when the input is empty (which is currently the case because we have no scripts 😅). By default on Linux the command is still run once with no input, and I'm guessing macOS does not run it at all (which by the way tbh seems the most sensible thing to do 🙂).
So either we wait to add at least one upgrade/downgrade script, or we add -r to skip xargs on empty.
|
Right, from the |
abd11e8 to
649953e
Compare
649953e to
d49015a
Compare
| name: swift-generated-cpp-files | ||
| path: swift/generated-cpp-files/** No newline at end of file | ||
| path: swift/generated-cpp-files/** | ||
| qlformat: |
There was a problem hiding this comment.
Hmm, this is most likely a rebase artifact, not sure where it comes from 🤔
There was a problem hiding this comment.
It's just a new line missing at the end of the file before this change. This adds a new line, so 114 changes.
There was a problem hiding this comment.
Assuming you also wanted to add a formatting check.
There was a problem hiding this comment.
Yeah, this is indeed a rebase artifact, the check was removed here #11214
redsun82
left a comment
There was a problem hiding this comment.
But please also update the obsolete PR description 🙂
This is inspired by the ruby checks.
The scripts check is running on macOS since the first command yields no results and breaks the whole invocation.Perhaps, xargs works differently on macOS and Linux?