Skip to content

CI: remove langauge specific format checks#11214

Merged
erik-krogh merged 2 commits into
github:mainfrom
erik-krogh:oneFormatToRuleThemAll
Nov 11, 2022
Merged

CI: remove langauge specific format checks#11214
erik-krogh merged 2 commits into
github:mainfrom
erik-krogh:oneFormatToRuleThemAll

Conversation

@erik-krogh

@erik-krogh erik-krogh commented Nov 10, 2022

Copy link
Copy Markdown
Contributor

We now have this format check which checks all the languages all the time, so there's no need for language specific format checks.

@erik-krogh erik-krogh marked this pull request as ready for review November 10, 2022 17:01
@erik-krogh erik-krogh requested a review from a team as a code owner November 10, 2022 17:01
@erik-krogh erik-krogh requested a review from a team November 10, 2022 17:01
@erik-krogh erik-krogh requested a review from a team as a code owner November 10, 2022 17:01
channel: 'release'
- name: check formatting
run: codeql query format */ql/{src,lib,test}/**/*.{qll,ql} --check-only
run: codeql query format */ql/**/*.{qll,ql} --check-only

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So, this expands the format check to every ql and qll file in the repo. I think that's fine.

@aibaars aibaars left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@erik-krogh erik-krogh merged commit 313f600 into github:main Nov 11, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants