make acronyms camelcase#10096
Conversation
There was a problem hiding this comment.
Found 14 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 14 potential problems in the proposed changes. Check the Files changed tab for more details.
| class CamelToUri extends string { | ||
| CamelToUri() { | ||
| exists(SpringCamelXmlToElement toXmlElement | this = toXmlElement.getUri()) or | ||
| exists(CamelJavaDSLToDecl toJavaDSL | this = toJavaDSL.getUri()) |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
f2a8456 to
62e8575
Compare
3ead1c4 to
be7aec4
Compare
be8982c to
a1244ec
Compare
There was a problem hiding this comment.
Found 17 potential problems in the proposed changes. Check the Files changed tab for more details.
There was a problem hiding this comment.
Found 17 potential problems in the proposed changes. Check the Files changed tab for more details.
c9faa9f to
bfcc678
Compare
| /** DEPRECATED: Alias for XmlDtd */ | ||
| deprecated class XmlDTD = XmlDtd; | ||
|
|
||
| /** DEPRECATED: Alias for XmlDtd */ | ||
| deprecated class XMLDTD = XmlDTD; |
There was a problem hiding this comment.
This was just introduced in your prior PR, so I think we can combine these aliases.
| /** DEPRECATED: Alias for XmlDtd */ | |
| deprecated class XmlDTD = XmlDtd; | |
| /** DEPRECATED: Alias for XmlDtd */ | |
| deprecated class XMLDTD = XmlDTD; | |
| /** DEPRECATED: Alias for XmlDtd */ | |
| deprecated class XMLDTD = XmlDtd; |
There was a problem hiding this comment.
Same for C++.
And the other languages, I'm fixing all in one go.
| /** DEPRECATED: Alias for SslServerSocket */ | ||
| deprecated class SSLServerSocket = SslServerSocket; |
There was a problem hiding this comment.
I don't think we need a deprecated alias in the experimental dir.
aschackmull
left a comment
There was a problem hiding this comment.
A couple of comments, otherwise Java LGTM.
|
In Go I notice a couple of cases where a |
|
Otherwise Go LGTM |
RasmusWL
left a comment
There was a problem hiding this comment.
Python 👍 besides the requested changes
@smowton: It's because it's |
smowton
left a comment
There was a problem hiding this comment.
Yeah ok on closer inspection the deprecated alias was for a nearby entity not the newtype itself
Co-authored-by: Rasmus Wriedt Larsen <rasmuswriedtlarsen@gmail.com>
There was a problem hiding this comment.
JS: 👍 LGTM. One comment is that the change note(s) make it sound as if this would be breaking a lot of customer code, when the old spelling is actually still supported in the form of a deprecated alias. Edit: Erik pointed out that the change note mentions that, I just missed it because I focused on only the diff :)
Acronyms should use normal PascalCase/camelCase.
This is a followup to #10073, and there might be more later.
Most of this PR was written automatically by my patching tool.
A QLDoc check was complaining about some missing QLDoc, so I fixed that (even though I didn't introduce the code 🤷).