rename all occurrences of XML to Xml#10073
Conversation
|
AFAIK generally we would keep the old name for public symbols and deprecate it to avoid a breaking change for 3rd-party queries? Given that, maybe it's best to restrict the rewrite to private symbols? |
I've left a deprecated alias with the old name for every rename, isn't that good enough? |
|
Oh sorry I somehow overlooked that, ignore me. |
dc2c568 to
7ef4172
Compare
| * ``` | ||
| */ | ||
| class XMLDTD extends XMLLocatable, @xmldtd { | ||
| class XmlDTD extends XmlLocatable, @xmldtd { |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
| * ``` | ||
| */ | ||
| class XMLDTD extends XMLLocatable, @xmldtd { | ||
| class XmlDTD extends XmlLocatable, @xmldtd { |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
| * ``` | ||
| */ | ||
| class XMLDTD extends XMLLocatable, @xmldtd { | ||
| class XmlDTD extends XmlLocatable, @xmldtd { |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
| * ``` | ||
| */ | ||
| class XMLDTD extends XMLLocatable, @xmldtd { | ||
| class XmlDTD extends XmlLocatable, @xmldtd { |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
| * ``` | ||
| */ | ||
| class XMLDTD extends XMLLocatable, @xmldtd { | ||
| class XmlDTD extends XmlLocatable, @xmldtd { |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
|
|
||
| /** Gets a DTD associated with this XML file. */ | ||
| XMLDTD getADTD() { xmlDTDs(result, _, _, _, this) } | ||
| XmlDTD getADTD() { xmlDTDs(result, _, _, _, this) } |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
|
|
||
| /** Gets a DTD associated with this XML file. */ | ||
| XMLDTD getADTD() { xmlDTDs(result, _, _, _, this) } | ||
| XmlDTD getADTD() { xmlDTDs(result, _, _, _, this) } |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
|
|
||
| /** Gets a DTD associated with this XML file. */ | ||
| XMLDTD getADTD() { xmlDTDs(result, _, _, _, this) } | ||
| XmlDTD getADTD() { xmlDTDs(result, _, _, _, this) } |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
|
|
||
| /** Gets a DTD associated with this XML file. */ | ||
| XMLDTD getADTD() { xmlDTDs(result, _, _, _, this) } | ||
| XmlDTD getADTD() { xmlDTDs(result, _, _, _, this) } |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
|
|
||
| /** Gets a DTD associated with this XML file. */ | ||
| XMLDTD getADTD() { xmlDTDs(result, _, _, _, this) } | ||
| XmlDTD getADTD() { xmlDTDs(result, _, _, _, this) } |
Check warning
Code scanning / CodeQL
Acronyms should be PascalCase/camelCase.
|
QL-for-QL is complaining that the |
kaeluka
left a comment
There was a problem hiding this comment.
Javascript: 👍, with an optional comment
| } | ||
|
|
||
| /** DEPRECATED: Alias for XmlDTD */ | ||
| deprecated class XMLDTD = XmlDTD; |
There was a problem hiding this comment.
while we're at it, can we name this one XmlDtd?
There was a problem hiding this comment.
I going to rename more things in a later PR.
I'll include DTD in that one.
Acronyms should use normal PascalCase/camelCase.
written automatically using my patching utility
The CI here is failing, and that is intended. Look at the CI checks in the internal PR (see the first backref below).
I've also deleted a dead method in java/kotlin-extractor/src/main/kotlin/utils/List.kt, because that method being dead caused the internal CI to fail.
This PR has to be merged at the same time as the internal PR.