Skip to content

ref(boto3): Move crumbs to integration - #7165

Open
sentrivana wants to merge 4 commits into
ivana/move-http-crumbs-4from
ivana/move-http-crumbs-5
Open

ref(boto3): Move crumbs to integration#7165
sentrivana wants to merge 4 commits into
ivana/move-http-crumbs-4from
ivana/move-http-crumbs-5

Conversation

@sentrivana

@sentrivana sentrivana commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Description

Set boto3 breadcrumbs in the integration directly, without relying on maybe_create_breadcrumbs_from_span.

Also, add breadcrumb tests to test_s3.py and remove the maybe_create_breadcrumbs_from_span util now that nothing needs it anymore.

Issues

Closes #7067

@sentrivana sentrivana mentioned this pull request Aug 11, 2026
Open
6 tasks
@sentrivana
sentrivana marked this pull request as ready for review August 11, 2026 10:36
@sentrivana
sentrivana requested a review from a team as a code owner August 11, 2026 10:36
cursor[bot]
cursor Bot reviewed Aug 11, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 7bd4d0b. Configure here.

Comment thread sentry_sdk/integrations/boto3.py
sentry[bot]
sentry Bot reviewed Aug 11, 2026
View reviewed changes
Comment thread sentry_sdk/integrations/boto3.py
@sentrivana
sentrivana marked this pull request as draft August 11, 2026 10:38
@sentrivana
sentrivana marked this pull request as ready for review August 11, 2026 10:51
@github-actions

github-actions Bot commented Aug 11, 2026

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 105373 passed | ❌ 1 failed | ⏭️ 6687 skipped | Total: 112061 | Pass Rate: 94.03% | Execution Time: 369m 9s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +1400
Passed Tests 📈 +1389
Failed Tests 📈 +1
Skipped Tests 📈 +10

➕ New Tests (1)

View new tests
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[non-experiment-thread]
    • File: tests.profiler.test_continuous_profiler
    • Status: ❌ Failing

❌ Failed Tests

test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[non-experiment-thread]

File: tests.profiler.test_continuous_profiler
Suite: py3.7-common
Error: AssertionError: profiler should not be running assert 'a3c91530abfb4f6696ec501e475bb793' is None + where 'a3c91530abfb4f6696ec501e475bb793' = get_profiler_id()

Stack Trace 
tests/profiler/test_continuous_profiler.py:896: in test_continuous_profiler_auto_start_and_stop_sampled_span_streaming
    assert get_profiler_id() is None, "profiler should not be running"
E   AssertionError: profiler should not be running
E   assert 'a3c91530abfb4f6696ec501e475bb793' is None
E    +  where 'a3c91530abfb4f6696ec501e475bb793' = get_profiler_id()

✅ Patch coverage is 100.00%. Project has 2476 uncovered lines.
✅ Project coverage is 90.18%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/boto3.py 100.00% ⚠️ 4 partials
Coverage diff 
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    90.14%    90.18%    +0.04%
==========================================
  Files          193       193         —
  Lines        25147     25223       +76
  Branches      9136      9176       +40
==========================================
+ Hits         22669     22747       +78
- Misses        2478      2476        -2
- Partials      1431      1434        +3

Generated by Codecov Action

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry sentry[bot] sentry[bot] left review comments
@cursor cursor[bot] cursor[bot] left review comments
@ericapisani ericapisani ericapisani approved these changes
@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@sentrivana @ericapisani @alexander-alderman-webb