test(httpx,httpx2): Split into sync/async tests - #7152
Merged
Conversation
sentrivana
marked this pull request as ready for review
August 10, 2026 13:45
Contributor
Codecov Results 📊✅ 99884 passed | ⏭️ 6677 skipped | Total: 106561 | Pass Rate: 93.73% | Execution Time: 357m 22s 📊 Comparison with Base Branch
✨ No test changes detected All tests are passing successfully. ✅ Patch coverage is 100.00%. Project has 2501 uncovered lines. Coverage diff@@ Coverage Diff @@
## main #PR +/-##
==========================================
+ Coverage 90.00% 90.03% +0.03%
==========================================
Files 193 193 —
Lines 25089 25089 —
Branches 9078 9078 —
==========================================
+ Hits 22581 22588 +7
- Misses 2508 2501 -7
- Partials 1439 1439 —Generated by Codecov Action |
ericapisani
approved these changes
Aug 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Instead of parametrizing on sync/async httpx(2) client, split each test case into a sync and async variant, with the async variant as a proper
async deffunction with@pytest.mark.parametrize.I did this because the tests routinely fail for me locally, and switching to using
pytest-asynciofixes that. The other reason is that for #7149, the breadcrumb tests don't simulate async very well, which leads to some scope problems and ultimately breadcrumbs not appearing on events in tests.I know this PR is not ideal since with the existing test duplication on span streaming/transaction tracing, we already have a LOT of test cases, and now many of them get an additional variant. But it does make them more resilient to random local (and I believe also CI) failures and we'll get rid of half of them on the new major branch.