ref(httpx,httpx2): Move crumbs to integrations - #7149
Conversation
| "reason": rv.reason_phrase, | ||
| } | ||
|
|
||
| if parsed_url and (not is_span_streaming_enabled or should_send_default_pii()): |
There was a problem hiding this comment.
The is_not_span_streaming_enabled part is there for continuity in transaction mode, where we don't care about should_send_default_pii before setting breadcrumb data.
Codecov Results 📊✅ 102197 passed | ❌ 136 failed | ⏭️ 6624 skipped | Total: 108957 | Pass Rate: 93.8% | Execution Time: 362m 8s 📊 Comparison with Base Branch
➕ New Tests (68)View new tests
❌ Failed Tests
|
Description
Move breadcrumbs from the centralized, span-powered
maybe_create_breadcrumbs_from_spandirectly to the HTTPX and HTTPX2 integrations. (Put the two together in one PR since they're the same changeset.)Additional changes:
pytest-asyncionow, as that simulates how the scopes behave live better than setting up an ad-hoc event loop.send_default_piibehavior)Issues
Reminders
uv run ruff.feat:,fix:,ref:,meta:)