Skip to content

ref(pyreqwest): Move crumbs to integration - #7148

Open
sentrivana wants to merge 5 commits into
ivana/move-http-crumbs-1from
ivana/move-http-crumbs-2
Open

ref(pyreqwest): Move crumbs to integration#7148
sentrivana wants to merge 5 commits into
ivana/move-http-crumbs-1from
ivana/move-http-crumbs-2

Conversation

@sentrivana

@sentrivana sentrivana commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Description

Create HTTP client breadcrumbs directly in the pyreqwest integration instead of using maybe_create_breadcrumbs_from_span.

Additionally:

  • refactor to use an early return in the wrapper to avoid nesting
  • add breadcrumb tests to the pyreqwest test suite

Issues

Reminders

@github-actions

github-actions Bot commented Aug 10, 2026 •
edited
Loading

Copy link
Copy Markdown
Contributor

Codecov Results 📊

✅ 101954 passed | ❌ 1 failed | ⏭️ 6635 skipped | Total: 108590 | Pass Rate: 93.89% | Execution Time: 365m 1s

📊 Comparison with Base Branch

Metric Change
Total Tests 📈 +2359
Passed Tests 📈 +2394
Failed Tests 📈 +1
Skipped Tests 📉 -36

➕ New Tests (1)

View new tests
  • test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[non-experiment-thread]
    • File: tests.profiler.test_continuous_profiler
    • Status: ❌ Failing

❌ Failed Tests

test_continuous_profiler_auto_start_and_stop_sampled_span_streaming[non-experiment-thread]

File: tests.profiler.test_continuous_profiler
Suite: py3.7-common
Error: AssertionError: profiler should not be running assert '93e8d40c4da84ef5b89b19a3c9f71cac' is None + where '93e8d40c4da84ef5b89b19a3c9f71cac' = get_profiler_id()

Stack Trace 
tests/profiler/test_continuous_profiler.py:896: in test_continuous_profiler_auto_start_and_stop_sampled_span_streaming
    assert get_profiler_id() is None, "profiler should not be running"
E   AssertionError: profiler should not be running
E   assert '93e8d40c4da84ef5b89b19a3c9f71cac' is None
E    +  where '93e8d40c4da84ef5b89b19a3c9f71cac' = get_profiler_id()

✅ Patch coverage is 96.55%. Project has 2506 uncovered lines.
✅ Project coverage is 90%. Comparing base (base) to head (head).

Files with missing lines (1)
File Patch % Lines
sentry_sdk/integrations/pyreqwest.py 96.43% ⚠️ 1 Missing and 3 partials
Coverage diff 
@@            Coverage Diff             @@
##          main       #PR       +/-##
==========================================
+ Coverage    89.99%    90.00%    +0.01%
==========================================
  Files          193       193         —
  Lines        25061     25054        -7
  Branches      9058      9048       -10
==========================================
+ Hits         22552     22548        -4
- Misses        2509      2506        -3
- Partials      1439      1435        -4

Generated by Codecov Action

@sentrivana sentrivana mentioned this pull request Aug 10, 2026
Open
5 tasks
@sentrivana
sentrivana marked this pull request as ready for review August 10, 2026 09:16
@sentrivana
sentrivana requested a review from a team as a code owner August 10, 2026 09:16
sentry[bot]
sentry Bot reviewed Aug 10, 2026
View reviewed changes
Comment thread sentry_sdk/integrations/pyreqwest.py Outdated
cursor[bot]
cursor Bot reviewed Aug 10, 2026
View reviewed changes
Comment thread sentry_sdk/integrations/pyreqwest.py Outdated
sentry[bot]
sentry Bot reviewed Aug 10, 2026
View reviewed changes
Comment thread sentry_sdk/integrations/pyreqwest.py Outdated
@sentrivana
sentrivana marked this pull request as draft August 10, 2026 09:53
@sentrivana
sentrivana marked this pull request as ready for review August 10, 2026 10:21
cursor[bot]
cursor Bot reviewed Aug 10, 2026
View reviewed changes

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Cursor Bugbot has reviewed your changes and found 1 potential issue.

Fix All in Cursor

❌ Bugbot Autofix is OFF. To automatically fix reported issues with cloud agents, enable autofix in the Cursor dashboard.

Reviewed by Cursor Bugbot for commit 579d224. Configure here.

Comment thread sentry_sdk/integrations/pyreqwest.py
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@sentry sentry[bot] sentry[bot] left review comments
@cursor cursor[bot] cursor[bot] left review comments
@alexander-alderman-webb alexander-alderman-webb alexander-alderman-webb approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

2 participants

@sentrivana @alexander-alderman-webb