Skip to content

fix(browser): Apply urlQueryParams to the Referer header - #25324

Merged
JPeer264 merged 1 commit into
developfrom
jp/browser-referer-sensitive-query-params
Oct 14, 2026
Merged

JPeer264 merged 1 commit into
developfrom
jp/browser-referer-sensitive-query-params

Conversation

@JPeer264

@JPeer264 JPeer264 commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

closes #25303
closes JS-3918

Description

This applies dataCollection.urlQueryParams to the Referer header that the browser SDK collects from document.referrer. Sensitive query params of the previous page are now filtered in request.headers.Referer of error events and static transactions, and in the http.request.header.referer span attribute.

Known issues

We do have a button to go to this page. By now adding filters we redirect to a potential broken page, but this can't and shouldn't be fixed, as this is filtered.

Screenshot 2026-10-13 at 14 21 34

Sentry events

Before (11.7.0), the Referer has jwt=sensitive-jwt-value: https://sentry-sdks.sentry.io/issues/7789837458/events/b27e43ad65b7405b8e030ebbcbff37e1/?project=4510555608449024
After, the Referer has jwt=[Filtered]: https://sentry-sdks.sentry.io/issues/7789837458/events/e5d05ddd3fd14c40a0c24e26e962223c/?project=4510555608449024

@linear-code

linear-code Bot commented Oct 13, 2026

Copy link
Copy Markdown

JS-3918

@github-actions

github-actions Bot commented Oct 13, 2026 •

Copy link
Copy Markdown
Contributor

size-limit report 📦

Path Size % Change Change
@sentry/browser 29.83 kB -0.02% -4 B 🔽
@sentry/browser - with treeshaking flags 27.96 kB +0.03% +7 B 🔺
@sentry/browser - with treeshaking flags tracing without tracing 27.87 kB -0.03% -7 B 🔽
@sentry/browser (incl. Tracing) 52.02 kB +0.01% +2 B 🔺
@sentry/browser (incl. Tracing + Span Streaming) 52.02 kB +0.01% +2 B 🔺
@sentry/browser (incl. Tracing, Profiling) 54.96 kB - -
@sentry/browser (incl. Tracing, Replay) 91.77 kB +0.03% +24 B 🔺
@sentry/browser (incl. Tracing, Replay) - with treeshaking flags 80.64 kB +0.02% +16 B 🔺
@sentry/browser (incl. Tracing, Replay with Canvas) 96.5 kB +0.03% +24 B 🔺
@sentry/browser (incl. Tracing, Replay, Feedback) 109.44 kB +0.01% +5 B 🔺
@sentry/browser (incl. Feedback) 47.34 kB -0.02% -5 B 🔽
@sentry/browser (incl. sendFeedback) 34.9 kB +0.03% +9 B 🔺
@sentry/browser (incl. FeedbackAsync) 39.99 kB -0.03% -9 B 🔽
@sentry/browser (incl. Metrics) 30.86 kB +0.02% +5 B 🔺
@sentry/browser (incl. Logs) 31.13 kB -0.01% -3 B 🔽
@sentry/browser (incl. Metrics & Logs) 31.76 kB -0.05% -15 B 🔽
@sentry/react 31.65 kB +0.02% +6 B 🔺
@sentry/react (incl. Tracing) 54.34 kB -0.01% -5 B 🔽
@sentry/vue 37.99 kB +0.04% +12 B 🔺
@sentry/vue (incl. Tracing) 54.96 kB +0.03% +12 B 🔺
@sentry/svelte 29.85 kB -0.03% -6 B 🔽
@sentry/remix (Remix 3 client bundle) 57.02 kB +0.02% +7 B 🔺
CDN Bundle 31.57 kB +0.03% +7 B 🔺
CDN Bundle (incl. Tracing) 52.53 kB +0.02% +9 B 🔺
CDN Bundle (incl. Logs, Metrics) 33.78 kB +0.04% +13 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) 54.47 kB +0.02% +8 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) 74.72 kB +0.02% +14 B 🔺
CDN Bundle (incl. Tracing, Replay) 90.2 kB +0.02% +10 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) 92.12 kB +0.02% +11 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) 96.35 kB +0.02% +13 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) 98.29 kB +0.02% +14 B 🔺
CDN Bundle - uncompressed 92.99 kB +0.01% +9 B 🔺
CDN Bundle (incl. Tracing) - uncompressed 155.84 kB +0.01% +11 B 🔺
CDN Bundle (incl. Logs, Metrics) - uncompressed 99.53 kB +0.01% +9 B 🔺
CDN Bundle (incl. Tracing, Logs, Metrics) - uncompressed 161.8 kB +0.01% +11 B 🔺
CDN Bundle (incl. Replay, Logs, Metrics) - uncompressed 229.57 kB +0.01% +9 B 🔺
CDN Bundle (incl. Tracing, Replay) - uncompressed 276.01 kB +0.01% +11 B 🔺
CDN Bundle (incl. Tracing, Replay, Logs, Metrics) - uncompressed 281.95 kB +0.01% +11 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback) - uncompressed 289.71 kB +0.01% +11 B 🔺
CDN Bundle (incl. Tracing, Replay, Feedback, Logs, Metrics) - uncompressed 295.65 kB +0.01% +11 B 🔺
@sentry/nextjs (client) 56.75 kB +0.01% +1 B 🔺
@sentry/sveltekit (client) 52.4 kB -0.01% -5 B 🔽
@sentry/core/server 40.99 kB - -
@sentry/core/browser 13.81 kB - -
@sentry/node 151.96 kB +0.01% +5 B 🔺
@sentry/node/import (ESM hook with diagnostics-channel injection) 83.78 kB - -
@sentry/node - without tracing 94.54 kB +0.01% +3 B 🔺
@sentry/node - without channel injection 130.14 kB +0.01% +5 B 🔺
@sentry/aws-serverless 102.69 kB +0.01% +6 B 🔺
@sentry/cloudflare (withSentry) - minified 210.38 kB - -
@sentry/cloudflare (withSentry) 521.61 kB - -
@sentry/nextjs/cloudflare (withSentry) - minified 228.06 kB - -

View base workflow run

@JPeer264

Copy link
Copy Markdown
Member Author

bugbot run

`document.referrer` holds the full URL of the previous page, including its
query string. `getHttpRequestData` now applies
`dataCollection.urlQueryParams` to it, so sensitive query params no longer
reach `request.headers.Referer` of error events and static transactions, or
the `http.request.header.referer` span attribute.

Co-Authored-By: Claude Opus 5.5 <noreply@anthropic.com>
@JPeer264
JPeer264 force-pushed the jp/browser-referer-sensitive-query-params branch from 70c9fc9 to 7958755 Compare October 13, 2026 14:15

@cursor cursor Bot left a comment

Copy link
Copy Markdown

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

✅ Bugbot reviewed your changes and found no new issues!

Comment @cursor review or bugbot run to trigger another review on this PR

Reviewed by Cursor Bugbot for commit 7958755. Configure here.

@JPeer264
JPeer264 marked this pull request as ready for review October 13, 2026 14:48
@JPeer264
JPeer264 requested a review from a team as a code owner October 13, 2026 14:48
@JPeer264
JPeer264 requested review from logaretm and msonnb and removed request for a team October 13, 2026 14:48
@JPeer264 JPeer264 self-assigned this Oct 13, 2026
@JPeer264
JPeer264 requested a review from Lms24 October 13, 2026 14:49

@msonnb msonnb left a comment •

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lol
Image

@JPeer264

Copy link
Copy Markdown
Member Author

ok TIL 😆

@JPeer264
JPeer264 merged commit f4ae6c5 into develop Oct 14, 2026
708 of 712 checks passed
@JPeer264
JPeer264 deleted the jp/browser-referer-sensitive-query-params branch October 14, 2026 17:10
@mfb

mfb commented Oct 15, 2026

Copy link
Copy Markdown

Would there be any interest in backporting this fix to the v10 branch?

@JPeer264

JPeer264 commented Oct 16, 2026 •

Copy link
Copy Markdown
Member Author

Hey, sorry our process with backporting seems to be a little intransparent. For the next weeks (undecided for how long) we'll automatically backport all fixes with Junior and will release them in a weekly-ish cadence. This fix should be out next week.

I just saw that junior didn't open up a backport PR for this one though - I'll check what happened

Edit: the PR has been opened now

JPeer264 pushed a commit that referenced this pull request Oct 16, 2026
JPeer264 pushed a commit that referenced this pull request Oct 16, 2026
nicohrubec added a commit that referenced this pull request Oct 16, 2026
Backport of: #25324

## Differences to the original PR

- `packages/browser/src/integrations/httpcontext.ts`: v10 has no
`dataCollection.httpHeaders` filtering in this integration, so only the
Referer query-param filtering was ported onto v10's simpler
implementation.
- `packages/browser/test/integrations/httpcontext.test.ts`: v10 stores
the referer span attribute as a string rather than an array, so the
assertions expect a string.
-
`dev-packages/browser-integration-tests/suites/integrations/httpContext/test.ts`:
the span-based integration test was left out because v10's httpContext
suite doesn't set up tracing; the unit test covers the span attribute.

This branch was prepared by the v10 backport automation, which was
blocked at PR creation; it's opened manually now.

<!-- junior-request-attribution:start -->
via **Jan Peer Stöcklmair**.
<!-- junior-request-attribution:end -->

<!-- junior-session-footer:start -->
<!-- junior-conversation-id:local%3Aweb%3A83fc948beed4fb12a54d41cb -->

--

[View Junior Session in
Sentry](https://sentry.sentry.io/explore/conversations/local%3Aweb%3A83fc948beed4fb12a54d41cb/?project=4510944073809921)

<!-- junior-session-footer:end -->

Co-authored-by: sentry-junior[bot] <264270552+sentry-junior[bot]@users.noreply.github.com>
Co-authored-by: Nicolas Hrubec <nicolas.hrubec@outlook.com>
renovate Bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 17, 2026
| datasource | package             | from  | to     |
| ---------- | ------------------- | ----- | ------ |
| npm        | @sentry/vite-plugin | 5.4.1 | 11.8.0 |


## [v11.8.0](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#1180)

##### Important Changes

- **feat(bundler-plugins): Release `@sentry/webpack-plugin`, `@sentry/vite-plugin`, `@sentry/rollup-plugin` and `@sentry/esbuild-plugin` from the SDK repository ([#25095](getsentry/sentry-javascript#25095

  The four standalone bundler plugins now release together with the SDK, so their version jumps from 5.4.1 to the SDK version. Each package re-exports the matching `@sentry/bundler-plugins` entry point, which we recommend for new projects. The plugin options do not change, but the update brings these breaking changes:

  - Node.js 20.19.0 or higher is required.
  - `@sentry/webpack-plugin` requires webpack 5.1 or higher. The `@sentry/webpack-plugin/webpack5` entry point still works and exports the same plugin as `@sentry/webpack-plugin`.
  - The plugins use the `sentry` CLI SDK instead of `@sentry/cli`. Sentry self-hosted 26.4.2 or higher is supported. Lower versions may continue to work.
  - Deploys that the plugins create on Vercel use the value of `VERCEL_TARGET_ENV` (`production`, `preview` or a custom name) as their environment, instead of `vercel-production` or `vercel-preview`. To keep the old value, set `release.deploy.env`.

- **feat(server-utils): Instrument the OpenAI decisions API as `gen_ai.decide` spans ([#25285](getsentry/sentry-javascript#25285

  OpenAI `decisions.create` calls now create `gen_ai.decide` spans.

##### Other Changes

- feat(core): Support SuppressedError in LinkedErrors integration ([#25246](getsentry/sentry-javascript#25246))
- fix(astro): Delete generated source maps for static output ([#25310](getsentry/sentry-javascript#25310))
- fix(astro): Upload source maps of Astro 7's prerender build ([#25309](getsentry/sentry-javascript#25309))
- fix(browser): Apply `urlQueryParams` to the Referer header ([#25324](getsentry/sentry-javascript#25324))
- fix(cloudflare): auto-instrument when wrangler `main` is a package ([#25343](getsentry/sentry-javascript#25343))
- fix(hono): Expose runtime-specific SDK options ([#25290](getsentry/sentry-javascript#25290))
- fix(node): Instrument Prisma 8 CollectionBase from rc.15 ([#25301](getsentry/sentry-javascript#25301))
- fix(nuxt): Skip 3xx/4xx Nuxt errors in the vue:error hook ([#25341](getsentry/sentry-javascript#25341))
- fix(server-utils): Read pi-durable 1.2.0 tool results from `output` ([#25312](getsentry/sentry-javascript#25312))
- fix(server-utils): Transform modules once when two Sentry Vite plugins add orchestrion ([#25043](getsentry/sentry-javascript#25043))
- fix(sveltekit): add op and origin to Kit's `sveltekit.endpoint` span ([#25376](getsentry/sentry-javascript#25376))
- fix(tanstackstart-react): Keep parametrized route names in Nitro 3 builds ([#25307](getsentry/sentry-javascript#25307))
- fix(tanstackstart-react): Rewrite source paths of split route modules ([#25361](getsentry/sentry-javascript#25361))

<details>
  <summary> <strong>Internal Changes</strong> </summary>

- chore: Add external contributor to CHANGELOG.md ([#25375](getsentry/sentry-javascript#25375))
- ci: Install the pnpm version that Volta pins ([#25287](getsentry/sentry-javascript#25287))
- license: Add cli FSL notice to package licenses ([#25314](getsentry/sentry-javascript#25314))
- ref(core): use shared MCP attribute conventions ([#25059](getsentry/sentry-javascript#25059))
- ref(tanstackstart-react): Reuse shared component annotation options ([#25313](getsentry/sentry-javascript#25313))
- test(browser): Keep whitespace text out of the handlers-lcp page ([#25280](getsentry/sentry-javascript#25280))
- test(bun): Restore [@sentry/core](https://github.com/sentry/core) spies after the Bun.serve tests ([#25276](getsentry/sentry-javascript#25276))
- test(bundler-plugins): Disable CLI telemetry in the CLI contract tests ([#25308](getsentry/sentry-javascript#25308))
- test(e2e): Add node-openai-decisions-send-to-sentry test app ([#25331](getsentry/sentry-javascript#25331))
- test(e2e): Add node-openai-send-to-sentry test app ([#24824](getsentry/sentry-javascript#24824))
- test(e2e): Add nuxt-5-sourcemaps test ([#25268](getsentry/sentry-javascript#25268))
- test(e2e): Inherit root Volta config in all e2e test apps ([#25369](getsentry/sentry-javascript#25369))
- test(e2e): Use an external host address for the Lambda DSN on loopback hostnames ([#25282](getsentry/sentry-javascript#25282))
- test(nextjs): Run nextjs-16-tunnel on Cloudflare ([#25161](getsentry/sentry-javascript#25161))
- test(nextjs): Switch DEBUG_BUILD with a getter instead of re-importing the SDK ([#25279](getsentry/sentry-javascript#25279))
- test(node): Await the child exit in the "should exit" integration tests ([#25277](getsentry/sentry-javascript#25277))
- test(node): Cover ioredis v6 in the diagnostics_channel suite ([#25300](getsentry/sentry-javascript#25300))
- test(node): Cover LangChain model calls made from a tool without config ([#25326](getsentry/sentry-javascript#25326))
- test(node): Log slow and failed Docker Compose starts in integration tests ([#25278](getsentry/sentry-javascript#25278))
- test(node): Unflake captureMessage with_level test ([#25358](getsentry/sentry-javascript#25358))
- test(sveltekit): Pin rollup to 4.64.5 ([#25328](getsentry/sentry-javascript#25328))

</details>

Work in this release was contributed by [@kunal649](https://github.com/kunal649) and [@mketiku](https://github.com/mketiku). Thank you for your contributions!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sensitive query parameters leak to Sentry in event Referer HTTP header

3 participants