Skip to content

fix(astro): Delete generated source maps for static output - #25310

Merged
Lms24 merged 2 commits into
lms/fix-astro-prerender-sourcemapsfrom
lms/fix-astro-static-sourcemaps-cleanup
Oct 14, 2026
Merged

Lms24 merged 2 commits into
lms/fix-astro-prerender-sourcemapsfrom
lms/fix-astro-static-sourcemaps-cleanup

Conversation

@Lms24

@Lms24 Lms24 commented Oct 13, 2026 •

Copy link
Copy Markdown
Member

When the SDK turns on hidden source maps, it deletes them after upload with globs for client and server folders. Static output has neither folder and writes client assets to <outDir>/_astro, so the maps stayed in dist and got deployed. This also deletes maps in the build.assets folder, and turns the leftover-maps check back on for the static variant of the astro-7-sourcemaps e2e app. Found while working on #25304.

@Lms24
Lms24 added this pull request to stack #25311 October 13, 2026 08:29
@Lms24
Lms24 marked this pull request as ready for review October 13, 2026 09:05
@Lms24
Lms24 requested a review from a team as a code owner October 13, 2026 09:05
@Lms24
Lms24 requested review from nicohrubec and s1gr1d and removed request for a team October 13, 2026 09:05
@Lms24 Lms24 self-assigned this Oct 13, 2026
Lms24 and others added 2 commits October 13, 2026 16:07
When the SDK enables hidden source maps, it deletes them after upload with
`./dist/**/client/**/*.map` and `./dist/**/server/**/*.map`. Static output
has neither folder and writes client assets to `<outDir>/_astro`, so the
maps stayed in `dist` and got deployed. Also delete maps in the
`build.assets` folder.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
Astro removes the hidden `.prerender` folder at the end of the build, so
these maps don't end up in the output today. Delete them ourselves anyway,
so we don't rely on Astro internals for maps the SDK turned on.

Co-Authored-By: Claude Opus 5.5 (1M context) <noreply@anthropic.com>
@Lms24
Lms24 force-pushed the lms/fix-astro-static-sourcemaps-cleanup branch from 11c7708 to 7af7d56 Compare October 13, 2026 14:08
@Lms24
Lms24 merged commit e8cc354 into develop Oct 14, 2026
53 of 82 checks passed
@Lms24
Lms24 deleted the lms/fix-astro-static-sourcemaps-cleanup branch October 14, 2026 09:07
renovate Bot added a commit to andrei-picus-tink/auto-renovate that referenced this pull request Oct 17, 2026
| datasource | package             | from  | to     |
| ---------- | ------------------- | ----- | ------ |
| npm        | @sentry/vite-plugin | 5.4.1 | 11.8.0 |


## [v11.8.0](https://github.com/getsentry/sentry-javascript/blob/HEAD/CHANGELOG.md#1180)

##### Important Changes

- **feat(bundler-plugins): Release `@sentry/webpack-plugin`, `@sentry/vite-plugin`, `@sentry/rollup-plugin` and `@sentry/esbuild-plugin` from the SDK repository ([#25095](getsentry/sentry-javascript#25095

  The four standalone bundler plugins now release together with the SDK, so their version jumps from 5.4.1 to the SDK version. Each package re-exports the matching `@sentry/bundler-plugins` entry point, which we recommend for new projects. The plugin options do not change, but the update brings these breaking changes:

  - Node.js 20.19.0 or higher is required.
  - `@sentry/webpack-plugin` requires webpack 5.1 or higher. The `@sentry/webpack-plugin/webpack5` entry point still works and exports the same plugin as `@sentry/webpack-plugin`.
  - The plugins use the `sentry` CLI SDK instead of `@sentry/cli`. Sentry self-hosted 26.4.2 or higher is supported. Lower versions may continue to work.
  - Deploys that the plugins create on Vercel use the value of `VERCEL_TARGET_ENV` (`production`, `preview` or a custom name) as their environment, instead of `vercel-production` or `vercel-preview`. To keep the old value, set `release.deploy.env`.

- **feat(server-utils): Instrument the OpenAI decisions API as `gen_ai.decide` spans ([#25285](getsentry/sentry-javascript#25285

  OpenAI `decisions.create` calls now create `gen_ai.decide` spans.

##### Other Changes

- feat(core): Support SuppressedError in LinkedErrors integration ([#25246](getsentry/sentry-javascript#25246))
- fix(astro): Delete generated source maps for static output ([#25310](getsentry/sentry-javascript#25310))
- fix(astro): Upload source maps of Astro 7's prerender build ([#25309](getsentry/sentry-javascript#25309))
- fix(browser): Apply `urlQueryParams` to the Referer header ([#25324](getsentry/sentry-javascript#25324))
- fix(cloudflare): auto-instrument when wrangler `main` is a package ([#25343](getsentry/sentry-javascript#25343))
- fix(hono): Expose runtime-specific SDK options ([#25290](getsentry/sentry-javascript#25290))
- fix(node): Instrument Prisma 8 CollectionBase from rc.15 ([#25301](getsentry/sentry-javascript#25301))
- fix(nuxt): Skip 3xx/4xx Nuxt errors in the vue:error hook ([#25341](getsentry/sentry-javascript#25341))
- fix(server-utils): Read pi-durable 1.2.0 tool results from `output` ([#25312](getsentry/sentry-javascript#25312))
- fix(server-utils): Transform modules once when two Sentry Vite plugins add orchestrion ([#25043](getsentry/sentry-javascript#25043))
- fix(sveltekit): add op and origin to Kit's `sveltekit.endpoint` span ([#25376](getsentry/sentry-javascript#25376))
- fix(tanstackstart-react): Keep parametrized route names in Nitro 3 builds ([#25307](getsentry/sentry-javascript#25307))
- fix(tanstackstart-react): Rewrite source paths of split route modules ([#25361](getsentry/sentry-javascript#25361))

<details>
  <summary> <strong>Internal Changes</strong> </summary>

- chore: Add external contributor to CHANGELOG.md ([#25375](getsentry/sentry-javascript#25375))
- ci: Install the pnpm version that Volta pins ([#25287](getsentry/sentry-javascript#25287))
- license: Add cli FSL notice to package licenses ([#25314](getsentry/sentry-javascript#25314))
- ref(core): use shared MCP attribute conventions ([#25059](getsentry/sentry-javascript#25059))
- ref(tanstackstart-react): Reuse shared component annotation options ([#25313](getsentry/sentry-javascript#25313))
- test(browser): Keep whitespace text out of the handlers-lcp page ([#25280](getsentry/sentry-javascript#25280))
- test(bun): Restore [@sentry/core](https://github.com/sentry/core) spies after the Bun.serve tests ([#25276](getsentry/sentry-javascript#25276))
- test(bundler-plugins): Disable CLI telemetry in the CLI contract tests ([#25308](getsentry/sentry-javascript#25308))
- test(e2e): Add node-openai-decisions-send-to-sentry test app ([#25331](getsentry/sentry-javascript#25331))
- test(e2e): Add node-openai-send-to-sentry test app ([#24824](getsentry/sentry-javascript#24824))
- test(e2e): Add nuxt-5-sourcemaps test ([#25268](getsentry/sentry-javascript#25268))
- test(e2e): Inherit root Volta config in all e2e test apps ([#25369](getsentry/sentry-javascript#25369))
- test(e2e): Use an external host address for the Lambda DSN on loopback hostnames ([#25282](getsentry/sentry-javascript#25282))
- test(nextjs): Run nextjs-16-tunnel on Cloudflare ([#25161](getsentry/sentry-javascript#25161))
- test(nextjs): Switch DEBUG_BUILD with a getter instead of re-importing the SDK ([#25279](getsentry/sentry-javascript#25279))
- test(node): Await the child exit in the "should exit" integration tests ([#25277](getsentry/sentry-javascript#25277))
- test(node): Cover ioredis v6 in the diagnostics_channel suite ([#25300](getsentry/sentry-javascript#25300))
- test(node): Cover LangChain model calls made from a tool without config ([#25326](getsentry/sentry-javascript#25326))
- test(node): Log slow and failed Docker Compose starts in integration tests ([#25278](getsentry/sentry-javascript#25278))
- test(node): Unflake captureMessage with_level test ([#25358](getsentry/sentry-javascript#25358))
- test(sveltekit): Pin rollup to 4.64.5 ([#25328](getsentry/sentry-javascript#25328))

</details>

Work in this release was contributed by [@kunal649](https://github.com/kunal649) and [@mketiku](https://github.com/mketiku). Thank you for your contributions!
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants